remove check_ownership from dataset_collections.contents

... since this api only needs to `check_accessible` as it is not modifying a collection
ahmedhamidawan · Feb 9, 2024 · f4d5e9c · f4d5e9c
1 parent 1e8e885
commit f4d5e9c
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/lib/galaxy/managers/collections.py b/lib/galaxy/managers/collections.py
@@ -802,7 +802,7 @@ def __get_history_collection_instance(
             raise RequestParameterInvalidException("History dataset collection association not found")
         # TODO: that sure looks like a bug, we can't check ownership using the history of the object we're checking ownership for ...
         history = getattr(trans, "history", collection_instance.history)
-        if check_ownership and collection_instance.history.published is False:
+        if check_ownership:
             self.history_manager.error_unless_owner(collection_instance.history, trans.user, current_history=history)
         if check_accessible:
             self.history_manager.error_unless_accessible(

diff --git a/lib/galaxy/webapps/galaxy/services/dataset_collections.py b/lib/galaxy/webapps/galaxy/services/dataset_collections.py
@@ -248,7 +248,7 @@ def contents(
                 "Parameter instance_type not being 'history' is not yet implemented."
             )
         hdca: HistoryDatasetCollectionAssociation = self.collection_manager.get_dataset_collection_instance(
-            trans, "history", hdca_id, check_ownership=True
+            trans, "history", hdca_id
         )
 
         # check to make sure the dsc is part of the validated hdca