slight optimization

`stringifyObject` does not need to be re-run for every selected value. Co-authored-by: Laila Los <[email protected]>
ahmedhamidawan · Oct 18, 2024 · b672e4a · b672e4a
1 parent d2f7f07
commit b672e4a
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/client/src/components/Form/Elements/FormSelectMany/worker/selectManyMain.ts b/client/src/components/Form/Elements/FormSelectMany/worker/selectManyMain.ts
@@ -47,8 +47,11 @@ export function main(options: UnwrapNestedRefs<UseSelectManyOptions>): UnwrapNes
     if (options.maintainSelectionOrder) {
         const selectedValuesArray = Array.from(selectedValues);
         selectedOptionsFiltered.sort((a, b) => {
-            const aIndex = selectedValuesArray.findIndex((v) => v === stringifyObject(a.value));
-            const bIndex = selectedValuesArray.findIndex((v) => v === stringifyObject(b.value));
+            const aAsString = stringifyObject(a.value);
+            const bAsString = stringifyObject(b.value);
+
+            const aIndex = selectedValuesArray.findIndex((v) => v === aAsString);
+            const bIndex = selectedValuesArray.findIndex((v) => v === bAsString);
             return aIndex - bIndex;
         });
     }