remove workflow running spinner from invocation view

since the progress bars already indicate that
ahmedhamidawan · Nov 21, 2024 · b04aa3a · b04aa3a
1 parent 5a17e0c
commit b04aa3a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/client/src/components/Workflow/WorkflowNavigationTitle.vue b/client/src/components/Workflow/WorkflowNavigationTitle.vue
@@ -1,5 +1,5 @@
 <script setup lang="ts">
-import { faEdit, faSitemap, faSpinner, faUpload } from "@fortawesome/free-solid-svg-icons";
+import { faEdit, faSitemap, faUpload } from "@fortawesome/free-solid-svg-icons";
 import { FontAwesomeIcon } from "@fortawesome/vue-fontawesome";
 import { BAlert, BButton, BButtonGroup } from "bootstrap-vue";
 import { storeToRefs } from "pinia";
@@ -28,7 +28,6 @@ interface Props {
     workflowId: string;
     runDisabled?: boolean;
     runWaiting?: boolean;
-    invocationRunning?: boolean;
     success?: boolean;
 }
 
@@ -104,8 +103,7 @@ const workflowImportTitle = computed(() => {
                 <div class="d-flex portlet-header align-items-center">
                     <div class="flex-grow-1" data-description="workflow heading">
                         <div class="px-1">
-                            <FontAwesomeIcon v-if="props.invocationRunning" :icon="faSpinner" spin />
-                            <FontAwesomeIcon v-else :icon="faSitemap" />
+                            <FontAwesomeIcon :icon="faSitemap" />
                             <b class="mx-1">
                                 {{ props.invocation ? "Invoked " : "" }}Workflow: {{ getWorkflowName() }}
                             </b>

diff --git a/client/src/components/WorkflowInvocationState/WorkflowInvocationState.vue b/client/src/components/WorkflowInvocationState/WorkflowInvocationState.vue
@@ -233,7 +233,6 @@ function cancelWorkflowSchedulingLocal() {
             v-if="props.isFullPage"
             :invocation="invocation"
             :workflow-id="invocation.workflow_id"
-            :invocation-running="!invocationAndJobTerminal"
             :success="props.success">
             <template v-slot:workflow-title-actions>
                 <BButton