Merge pull request galaxyproject#17701 from dannon/activity-bar-on

Activity bar preference handling fixes.
ahmedhamidawan · Mar 14, 2024 · 999f3d5 · 999f3d5
2 parents 0c588fd + c50240c
commit 999f3d5
Show file tree

Hide file tree

Showing 8 changed files with 9 additions and 69 deletions.
diff --git a/client/src/components/Common/PublishedItem.vue b/client/src/components/Common/PublishedItem.vue
@@ -46,12 +46,12 @@ const pluralPath = computed(() => plural.value.toLowerCase());
 const publishedByUser = computed(() => `/${pluralPath.value}/list_published?f-username=${owner.value}`);
 const urlAll = computed(() => `/${pluralPath.value}/list_published`);
 
-const { showActivityBar, showToolbox } = usePanels();
+const { showToolbox } = usePanels();
 </script>
 
 <template>
     <div id="columns" class="d-flex">
-        <ActivityBar v-if="showActivityBar" />
+        <ActivityBar />
 
         <FlexPanel v-if="showToolbox" side="left">
             <ToolPanel />

diff --git a/client/src/components/Masthead/Masthead.vue b/client/src/components/Masthead/Masthead.vue
@@ -16,7 +16,7 @@ import { getActiveTab } from "./utilities";
 
 import NotificationsBell from "@/components/Notifications/NotificationsBell.vue";
 
-const { isAnonymous, showActivityBar } = storeToRefs(useUserStore());
+const { isAnonymous } = storeToRefs(useUserStore());
 
 const route = useRoute();
 const { config, isConfigLoaded } = useConfig();
@@ -139,7 +139,7 @@ onMounted(() => {
                 @open-url="emit('open-url', $event)" />
             <MastheadItem v-if="windowTab" :tab="windowTab" :toggle="windowToggle" @click="onWindowToggle" />
             <BNavItem
-                v-if="!isAnonymous && isConfigLoaded && config.enable_notification_system && !showActivityBar"
+                v-if="!isAnonymous && isConfigLoaded && config.enable_notification_system"
                 id="notifications-bell">
                 <NotificationsBell tooltip-placement="bottom" />
             </BNavItem>

diff --git a/client/src/components/User/UserActivityBarSettings.vue b/client/src/components/User/UserActivityBarSettings.vue
diff --git a/client/src/components/User/UserPreferences.vue b/client/src/components/User/UserPreferences.vue
@@ -67,16 +67,6 @@
             title="Manage Custom Builds"
             description="Add or remove custom builds using history datasets."
             to="/custom_builds" />
-        <UserPreferencesElement
-            icon="fa-th-list"
-            title="Manage Activity Bar"
-            description="Click here to show or hide the activity bar."
-            badge="New!"
-            @click="toggleActivityBar = !toggleActivityBar">
-            <b-collapse v-model="toggleActivityBar">
-                <UserActivityBarSettings />
-            </b-collapse>
-        </UserPreferencesElement>
         <UserPreferencesElement
             v-if="hasThemes"
             icon="fa-palette"
@@ -148,7 +138,6 @@ import Vue from "vue";
 import { useConfig } from "@/composables/config";
 import { useUserStore } from "@/stores/userStore";
 
-import UserActivityBarSettings from "./UserActivityBarSettings";
 import UserBeaconSettings from "./UserBeaconSettings";
 import UserDeletion from "./UserDeletion";
 import UserPreferencesElement from "./UserPreferencesElement";
@@ -160,7 +149,6 @@ Vue.use(BootstrapVue);
 
 export default {
     components: {
-        UserActivityBarSettings,
         UserDeletion,
         UserPreferencesElement,
         ThemeSelector,
@@ -190,7 +178,6 @@ export default {
             message: null,
             showLogoutModal: false,
             showDataPrivateModal: false,
-            toggleActivityBar: false,
             toggleTheme: false,
         };
     },

diff --git a/client/src/components/Workflow/Published/WorkflowPublished.vue b/client/src/components/Workflow/Published/WorkflowPublished.vue
@@ -130,7 +130,7 @@ watch(
     }
 );
 
-const { showActivityBar, showToolbox } = usePanels();
+const { showToolbox } = usePanels();
 
 const downloadUrl = computed(() => withPrefix(`/api/workflows/${props.id}/download?format=json-download`));
 const importUrl = computed(() => withPrefix(`/workflow/imp?id=${props.id}`));
@@ -156,7 +156,7 @@ const viewUrl = computed(() => withPrefix(`/published/workflow?id=${props.id}`))
 
 <template>
     <div id="columns" class="d-flex">
-        <ActivityBar v-if="!props.embed && showActivityBar" />
+        <ActivityBar v-if="!props.embed" />
         <FlexPanel v-if="!props.embed && showToolbox" side="left">
             <ToolPanel />
         </FlexPanel>

diff --git a/client/src/composables/usePanels.ts b/client/src/composables/usePanels.ts
@@ -1,10 +1,7 @@
 import { computed } from "vue";
 import { useRoute } from "vue-router/composables";
 
-import { useUserStore } from "@/stores/userStore";
-
 export function usePanels() {
-    const userStore = useUserStore();
     const route = useRoute();
 
     const showPanels = computed(() => {
@@ -15,12 +12,10 @@ export function usePanels() {
         return true;
     });
 
-    const showActivityBar = computed(() => showPanels.value && userStore.showActivityBar);
-    const showToolbox = computed(() => showPanels.value && !showActivityBar.value);
+    const showToolbox = computed(() => showPanels.value);
 
     return {
         showPanels,
-        showActivityBar,
         showToolbox,
     };
 }
diff --git a/client/src/entry/analysis/modules/Analysis.vue b/client/src/entry/analysis/modules/Analysis.vue
@@ -8,12 +8,11 @@ import CenterFrame from "./CenterFrame.vue";
 import ActivityBar from "@/components/ActivityBar/ActivityBar.vue";
 import HistoryIndex from "@/components/History/Index.vue";
 import FlexPanel from "@/components/Panels/FlexPanel.vue";
-import ToolPanel from "@/components/Panels/ToolPanel.vue";
 import DragAndDropModal from "@/components/Upload/DragAndDropModal.vue";
 
 const router = useRouter();
 const showCenter = ref(false);
-const { showActivityBar, showToolbox, showPanels } = usePanels();
+const { showPanels } = usePanels();
 
 // methods
 function hideCenter() {
@@ -38,10 +37,7 @@ onUnmounted(() => {
 
 <template>
     <div id="columns" class="d-flex">
-        <ActivityBar v-if="showActivityBar" />
-        <FlexPanel v-if="showToolbox" side="left">
-            <ToolPanel />
-        </FlexPanel>
+        <ActivityBar />
         <div id="center" class="overflow-auto p-3 w-100">
             <CenterFrame v-show="showCenter" id="galaxy_main" @load="onLoad" />
             <router-view v-show="!showCenter" :key="$route.fullPath" class="h-100" />

diff --git a/client/src/stores/userStore.ts b/client/src/stores/userStore.ts
@@ -43,7 +43,6 @@ export const useUserStore = defineStore("userStore", () => {
 
     // explicitly pass current User, because userStore might not exist yet
     const toggledSideBar = useUserLocalStorage("user-store-toggled-side-bar", "tools", currentUser);
-    const showActivityBar = useUserLocalStorage("user-store-show-activity-bar", true, currentUser);
     const preferredListViewMode = useUserLocalStorage("user-store-preferred-list-view-mode", "grid", currentUser);
 
     let loadPromise: Promise<void> | null = null;
@@ -135,10 +134,6 @@ export const useUserStore = defineStore("userStore", () => {
         preferredListViewMode.value = view;
     }
 
-    function toggleActivityBar() {
-        showActivityBar.value = !showActivityBar.value;
-    }
-
     function toggleSideBar(currentOpen = "") {
         toggledSideBar.value = toggledSideBar.value === currentOpen ? "" : currentOpen;
     }
@@ -153,7 +148,6 @@ export const useUserStore = defineStore("userStore", () => {
         isAnonymous,
         currentTheme,
         currentFavorites,
-        showActivityBar,
         toggledSideBar,
         preferredListViewMode,
         loadUser,
@@ -162,7 +156,6 @@ export const useUserStore = defineStore("userStore", () => {
         setPreferredListViewMode,
         addFavoriteTool,
         removeFavoriteTool,
-        toggleActivityBar,
         toggleSideBar,
         isRegisteredUser,
         $reset,