Skip to content

Commit

Permalink
Fix flaky `test/integration_selenium/test_toolbox_filters.py::TestToo…
Browse files Browse the repository at this point in the history
…lboxFiltersSeleniumIntegration::test_toolbox_filters`

Fixes galaxyproject#18832
  • Loading branch information
ahmedhamidawan committed Sep 19, 2024
1 parent 0863221 commit 55c45f3
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 0 deletions.
1 change: 1 addition & 0 deletions client/src/utils/navigation/navigation.yml
Original file line number Diff line number Diff line change
Expand Up @@ -374,6 +374,7 @@ edit_collection_attributes:

tool_panel:
selectors:
tool_box: '[data-description="panel toolbox"]'
tool_link: 'a[href$$="tool_runner?tool_id=${tool_id}"]'
outer_tool_link: '.toolTitle a[href$$="tool_runner?tool_id=${tool_id}"]'
data_source_tool_link: 'a[href$$="tool_runner/data_source_redirect?tool_id=${tool_id}"]'
Expand Down
3 changes: 3 additions & 0 deletions test/integration_selenium/test_toolbox_filters.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ def test_toolbox_filters(self):
the specified section is no longer displayed in the browser.
"""
self.register()
self.sleep_for(self.wait_types.UX_RENDER)
self.components.tool_panel.tool_box.wait_for_visible()
# The tool panel section should be visible and clickable at this stage
section = self.driver.find_element(By.LINK_TEXT, "Test Section")
self.action_chains().move_to_element(section).click().perform()
Expand All @@ -41,6 +43,7 @@ def test_toolbox_filters(self):
self.components.toolbox_filters.submit.wait_for_and_click()
self.sleep_for(self.wait_types.UX_RENDER)
self.home()
self.components.tool_panel.tool_box.wait_for_visible()
# But now it should raise NoSuchElementException
with self.assertRaises(NoSuchElementException):
self.driver.find_element(By.LINK_TEXT, "Test Section")

0 comments on commit 55c45f3

Please sign in to comment.