export explicit types for content source and type

Co-authored-by: David López <[email protected]>
ahmedhamidawan · Aug 19, 2024 · 42c2c9b · 42c2c9b
1 parent f99d3d1
commit 42c2c9b
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/client/src/api/datasets.ts b/client/src/api/datasets.ts
@@ -67,7 +67,7 @@ export async function purgeDataset(datasetId: string) {
 }
 
 const datasetCopy = fetcher.path("/api/histories/{history_id}/contents/{type}s").method("post").create();
-export type HistoryContentsArgs = FetchArgType<typeof datasetCopy>;
+type HistoryContentsArgs = FetchArgType<typeof datasetCopy>;
 export async function copyDataset(
     datasetId: HistoryContentsArgs["content"],
     historyId: HistoryContentsArgs["history_id"],
@@ -95,3 +95,6 @@ export async function fetchDatasetAttributes(datasetId: string) {
 
     return data;
 }
+
+export type HistoryContentType = components["schemas"]["HistoryContentType"];
+export type HistoryContentSource = components["schemas"]["HistoryContentSource"];
diff --git a/client/src/components/History/CurrentHistory/HistoryPanel.vue b/client/src/components/History/CurrentHistory/HistoryPanel.vue
@@ -11,7 +11,7 @@ import {
     isHistoryItem,
     userOwnsHistory,
 } from "@/api";
-import { copyDataset, HistoryContentsArgs } from "@/api/datasets";
+import { copyDataset, type HistoryContentSource, type HistoryContentType } from "@/api/datasets";
 import ExpandedItems from "@/components/History/Content/ExpandedItems";
 import SelectedItems from "@/components/History/Content/SelectedItems";
 import { HistoryFilters } from "@/components/History/HistoryFilters";
@@ -399,8 +399,8 @@ async function onDrop() {
     try {
         // iterate over the data array and copy each item to the current history
         for (const item of data) {
-            let dataSource: HistoryContentsArgs["source"];
-            let type: HistoryContentsArgs["type"];
+            let dataSource: HistoryContentSource;
+            let type: HistoryContentType;
             let id: string;
             if (isHistoryItem(item)) {
                 dataSource = item.history_content_type === "dataset" ? "hda" : "hdca";