prioritize link to subworkflow in invocation view

... and disable Report tab in subworkflow step
ahmedhamidawan · Aug 23, 2024 · 1196d2a · 1196d2a
1 parent a3156c0
commit 1196d2a
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 17 deletions.
diff --git a/client/src/components/WorkflowInvocationState/WorkflowInvocationOverview.vue b/client/src/components/WorkflowInvocationState/WorkflowInvocationOverview.vue
@@ -154,6 +154,12 @@ function onCancel() {
 
 <template>
     <div class="mb-3 workflow-invocation-state-component">
+        <BAlert v-if="invocation && isSubworkflow" variant="secondary" show>
+            This subworkflow is
+            <HelpText :uri="`galaxy.invocations.states.${invocation.state}`" :text="invocation.state" />.
+            <ExternalLink :href="withPrefix(`/workflows/invocations/${invocation.id}`)"> Click here </ExternalLink>
+            to view this subworkflow in graph view.
+        </BAlert>
         <div v-if="!invocationAndJobTerminal">
             <BAlert variant="info" show>
                 <LoadingSpan :message="`Waiting to complete invocation ${indexStr}`" />
@@ -225,23 +231,15 @@ function onCancel() {
             </div>
         </div>
         <!-- An invocation has been loaded, display the graph -->
-        <div v-if="invocation">
-            <div v-if="workflow && !isSubworkflow">
-                <InvocationGraph
-                    class="mt-1"
-                    :invocation="invocation"
-                    :workflow="workflow"
-                    :is-terminal="invocationAndJobTerminal"
-                    :is-scheduled="invocationSchedulingTerminal"
-                    :is-full-page="isFullPage"
-                    :show-minimap="isFullPage" />
-            </div>
-            <BAlert v-else-if="isSubworkflow" variant="secondary" show>
-                This subworkflow is
-                <HelpText :uri="`galaxy.invocations.states.${invocation.state}`" :text="invocation.state" />.
-                <ExternalLink :href="withPrefix(`/workflows/invocations/${invocation.id}`)"> Click here </ExternalLink>
-                to view this subworkflow in graph view.
-            </BAlert>
+        <div v-if="invocation && workflow && !isSubworkflow">
+            <InvocationGraph
+                class="mt-1"
+                :invocation="invocation"
+                :workflow="workflow"
+                :is-terminal="invocationAndJobTerminal"
+                :is-scheduled="invocationSchedulingTerminal"
+                :is-full-page="isFullPage"
+                :show-minimap="isFullPage" />
         </div>
     </div>
 </template>
diff --git a/client/src/components/WorkflowInvocationState/WorkflowInvocationState.vue b/client/src/components/WorkflowInvocationState/WorkflowInvocationState.vue
@@ -252,6 +252,7 @@ function getWorkflowName() {
                 <p>TODO: Insert readonly version of workflow editor here</p>
             </BTab> -->
             <BTab
+                v-if="!props.isSubworkflow"
                 title="Report"
                 title-item-class="invocation-report-tab"
                 :disabled="!invocationStateSuccess || !workflow"