Skip to content

Commit

Permalink
Fix latest tag check
Browse files Browse the repository at this point in the history
Our check that (when we make a new release) the Docker image is tagged
with latest as well as the new semver version number, which we added in
[v1.6.14][1] was broken. This was because we were not pulling the latest
tag docker image during the check, so it was not present. Fixed in this
commit.

[1]: https://github.com/agilepathway/label-checker/releases/tag/v1.6.14
  • Loading branch information
johnboyes authored Jan 21, 2024
1 parent c9c005d commit 6ebed5e
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/github_tag_and_release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -81,8 +81,10 @@ jobs:
# (it is important to have this check to catch any regression, e.g. if we move to a different way of releasing)
id: check_docker_image_tagged_latest
# yamllint disable rule:line-length
# we need to pull both docker tags to do the check
run: |
docker pull ${{env.docker_repo}}:${{ needs.tag.outputs.semver }}
docker pull ${{env.docker_repo}}:latest
echo "IS_LATEST_TAGGED_CORRECTLY=$(docker image inspect ${{env.docker_repo}}:${{ needs.tag.outputs.semver }} | jq -r '.[] | (.RepoTags) | any( . == "${{env.docker_repo}}:latest") ')" >> "$GITHUB_OUTPUT"
# yamllint enable rule:line-length

Expand Down

0 comments on commit 6ebed5e

Please sign in to comment.