generated from actions/container-action
-
Notifications
You must be signed in to change notification settings - Fork 10
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Pin major versions of GitHub Actions dependencies (#359)
Prior to this commit we were pinning to patch level dependencies. Just pinning to major versions will make the application easier to maintain - fewer updates. We have sufficiently high test coverage to feel we can make this change safely. If it causes a problem in the future (which is unlikely) we can pin specific dependencies at minor or patch level again if needed. We have left some of the dependencies still pinned to patch versions, for instance the tag and release dependencies, as we need to be very careful with them. We will investigate those dependencies more closely at some time in the future and may pin them just to major versions in a new pull request if we think it's safe enough.
- Loading branch information
Showing
9 changed files
with
22 additions
and
23 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -20,8 +20,7 @@ jobs: | |
# 4. integration_test.yml | ||
# 5. virtual_test.yml | ||
# 6. the go.mod (if it is a major or minor version change e.g. 1.14 to 1.15) | ||
# NB apart from go.mod, always specify the patch level version e.g 1.15.1 | ||
# (bear in mind there is no `.0` patch level version though, i.e. use 1.15 not 1.15.0) | ||
# NB bear in mind there is no `.0` patch level version, i.e. use 1.15 not 1.15.0 | ||
- uses: golang/[email protected] | ||
|
||
# update the versions in the devcontainer Dockerfile manually, too | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -30,12 +30,12 @@ jobs: | |
steps: | ||
- | ||
name: Checkout | ||
uses: actions/checkout@v2.3.4 | ||
uses: actions/checkout@v2 | ||
with: | ||
fetch-depth: 0 | ||
- | ||
name: Set up Go | ||
uses: actions/setup-go@v2.1.3 | ||
uses: actions/setup-go@v2 | ||
with: | ||
go-version: 1.20.1 | ||
- | ||
|
@@ -52,7 +52,7 @@ jobs: | |
name: Build and push image | ||
runs-on: ubuntu-22.04 | ||
steps: | ||
- uses: actions/checkout@v2.3.4 | ||
- uses: actions/checkout@v2 | ||
- uses: docker/[email protected] | ||
with: | ||
username: ${{ secrets.DOCKER_USERNAME }} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters