Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linux: Enable Broadcom STB I2C bus driver #1385

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

eigendude
Copy link
Contributor

- What I did

This PR enables the Broadcom STB I2C bus driver in the kernel config.

Without this change, when I enable the GPU on my Pi 4, my HDMI TFT display shows U-boot doing its thing then goes blank.

Enabling the STB I2C bus fixes the problem by letting Linux communicate through the Display Data Channel (DDC) to allow the TFT display to work.

- How I did it

I enabled the CONFIG_I2C_BRCMSTB option in vc4graphics.cfg to ensure proper support for the brcm,bcm2711-hdmi-i2c device node.

Without this configuration, the I2C bus associated with HDMI on Broadcom BCM2711-based systems may fail to probe, causing issues with HDMI communication and display initialization.

Additionally, this resolves potential deferred probe issues observed in the kernel logs, ensuring the correct initialization of the HDMI I2C bus.

@agherzan agherzan enabled auto-merge (rebase) November 5, 2024 18:48
Copy link
Owner

@agherzan agherzan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Looks good to me.

This patch enables the CONFIG_I2C_BRCMSTB option in vc4graphics.cfg to
ensure proper support for the `brcm,bcm2711-hdmi-i2c` device node. Without
this configuration, the I2C bus associated with HDMI on Broadcom
BCM2711-based systems may fail to probe, causing issues with HDMI
communication and display initialization.

Additionally, this resolves potential deferred probe issues observed in
the kernel logs, ensuring the correct initialization of the HDMI I2C bus.

Signed-off-by: Garrett Brown <[email protected]>
@agherzan agherzan disabled auto-merge December 5, 2024 20:09
@agherzan agherzan merged commit aea47ad into agherzan:master Dec 5, 2024
18 of 19 checks passed
@agherzan
Copy link
Owner

agherzan commented Dec 5, 2024

Merged. Thanks for this.

@eigendude eigendude deleted the enable-hdmi-i2c branch December 16, 2024 04:02
@eigendude
Copy link
Contributor Author

I'm currently working on scarthgap, would you like a backport of this?

@agherzan
Copy link
Owner

@eigendude A clean cherry-pick would be nice indeed. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants