Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpi-base: Added missing HiFiBerry #1287

Merged
merged 2 commits into from
Mar 5, 2024
Merged

rpi-base: Added missing HiFiBerry #1287

merged 2 commits into from
Mar 5, 2024

Conversation

kluszon
Copy link
Contributor

@kluszon kluszon commented Feb 21, 2024

- What I did

Added missing support for HiFiBerry AMP100, AMP3, AMP4 Pro, DAC+ ADC Pro, DAC+ DSP, DAC+ HD, Digi Pro.

- How I did it

Add right lines to rpi-base.inc. Changes were tested and works fine with the branch.

Connected also with issue #1168

Copy link
Owner

@agherzan agherzan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks!

@agherzan agherzan enabled auto-merge (rebase) February 22, 2024 13:13
@kluszon
Copy link
Contributor Author

kluszon commented Feb 23, 2024

@agherzan What is wrong with DCO? The commit message has required formatting.

@kraj
Copy link
Collaborator

kraj commented Feb 23, 2024

@agherzan What is wrong with DCO? The commit message has required formatting.

DCO - Developer Certificate of Origin, basically you add Signed-off-by: tag to indicate that the work came from you.

auto-merge was automatically disabled February 26, 2024 06:50

Head branch was pushed to by a user without write access

@kluszon kluszon force-pushed the master branch 2 times, most recently from e9ef789 to d0ed403 Compare February 26, 2024 06:51
@kluszon
Copy link
Contributor Author

kluszon commented Feb 26, 2024

@kraj

DCO - Developer Certificate of Origin, basically you add Signed-off-by: tag to indicate that the work came from you.

I know that. Strange because the commit had "Signed-off-by" section. I did rebase, removed it and added it again.

@kluszon kluszon requested a review from agherzan February 26, 2024 07:02
@agherzan
Copy link
Owner

It's an edge case on the CI side. It falls apart when the incoming branch is the same as the destination branch (in name). "master" and "master" in this case. Don't worry about it.

@agherzan
Copy link
Owner

@kluszon Can you please cleanup the merge commits?

Added support for missing HiFiBerry AMP100, AMP3, AMP4 Pro, DAC+ ADC Pro, DAC+ DSP, DAC+ HD, Digi Pro.

Signed-off-by: Michał Kluska <kluska.mk@gmail.com>
@kluszon
Copy link
Contributor Author

kluszon commented Feb 27, 2024

@agherzan I removed any other changes. Please merge it.

Copy link
Owner

@agherzan agherzan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks great!

@agherzan agherzan merged commit 92a9b7a into agherzan:master Mar 5, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants