-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rpi-base: Added missing HiFiBerry #1287
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks!
@agherzan What is wrong with DCO? The commit message has required formatting. |
DCO - Developer Certificate of Origin, basically you add Signed-off-by: tag to indicate that the work came from you. |
Head branch was pushed to by a user without write access
e9ef789
to
d0ed403
Compare
I know that. Strange because the commit had "Signed-off-by" section. I did rebase, removed it and added it again. |
It's an edge case on the CI side. It falls apart when the incoming branch is the same as the destination branch (in name). "master" and "master" in this case. Don't worry about it. |
@kluszon Can you please cleanup the merge commits? |
Added support for missing HiFiBerry AMP100, AMP3, AMP4 Pro, DAC+ ADC Pro, DAC+ DSP, DAC+ HD, Digi Pro. Signed-off-by: Michał Kluska <kluska.mk@gmail.com>
@agherzan I removed any other changes. Please merge it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This looks great!
- What I did
Added missing support for HiFiBerry AMP100, AMP3, AMP4 Pro, DAC+ ADC Pro, DAC+ DSP, DAC+ HD, Digi Pro.
- How I did it
Add right lines to rpi-base.inc. Changes were tested and works fine with the branch.
Connected also with issue #1168