Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linux-raspberrypi: stop setting powersave as the default CPU governor #1231

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

clopez
Copy link
Contributor

@clopez clopez commented Oct 20, 2023

  • The defconfigs from the RPi Kernel set powersave as the default CPU governor, which is a bad idea as that reduces performance by setting the CPU frequency to the minimum one.

  • In case of a Yocto build user-space is not configured by default to change the CPU governor, so powersave will remain the CPU governor and it will slow down everything.

  • I submitted a fix for those defconfigs to upstream here: configs: stop defaulting to the powersave governor raspberrypi/linux#5666 However, we shouldn't wait until that is accepted and backported to all the stable branches (if ever is).

  • This patch unsets the selection of powersave as the default CPU governor.

  • Then the CPU governor that will be selected as default after this patch will be the Linux's default one that is either ondemand or schedutil depending on the Kernel version.

Copy link
Collaborator

@kraj kraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Copy link
Owner

@agherzan agherzan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@agherzan agherzan force-pushed the fix_default_cpu_governor branch from 22a28b0 to dc90358 Compare October 24, 2023 11:39
@agherzan agherzan enabled auto-merge (rebase) October 24, 2023 11:40
* The defconfigs from the RPi Kernel set `powersave` as the default
  CPU governor, which is a bad idea as that reduces performance by
  setting the CPU frequency to the minimum one.

* In case of a Yocto build user-space is not configured by default
  to change the CPU governor, so `powersave` will remain the CPU
  governor and it will slow down everything.

* I submitted a fix for those defconfigs to upstream here:
  raspberrypi/linux#5666
  However, we shouldn't wait until that is accepted and backported
  to all the stable branches (if ever is).

* This patch unsets the selection of `powersave` as the default CPU
  governor.

* Then the CPU governor that will be selected as default after this
  patch will be the Linux's default one that is either `ondemand` or
  `schedutil` depending on the Kernel version.

Signed-off-by: Carlos Alberto Lopez Perez <[email protected]>
@agherzan agherzan force-pushed the fix_default_cpu_governor branch from dc90358 to 1248b3b Compare October 25, 2023 09:01
@agherzan agherzan merged commit 0a4a68d into agherzan:master Oct 25, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants