Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing string sanitation #26

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

bencon
Copy link

@bencon bencon commented Nov 8, 2019

This PR fixes issue Missing string sanitation before passing failure text to xmlbuilder #27

Below is an example of TAP input that would causes tap-xunit to throw an exception and abort. Adding the missing string sanitation to strip out an odd unicode character fixes this.

TAP version 13
not ok 99 - some test
  ---
    name: AssertionError
    message: " Uncaught TypeError: Cannot read property 'slice' of undefined\\n\\n %c\U0001F477‍ This is a development only message. It will be removed in production builds.\""
    assertion: fail
    at: 'forEach (someFile)'
  ...
# blah blah

1..105
# tests 105
# pass 100
# skip 4
# fail 1

@bencon
Copy link
Author

bencon commented Nov 8, 2019

@aghassemi Mind taking a quick peek at this one liner fix? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant