-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add BGC to ODE wrapper function #78
base: main
Are you sure you want to change the base?
Conversation
For SODEs we would also need StochasticDiffEq.jl. However, looking at the dependencies, this package also does not rely on BoundaryValueDiffEq.jl Of course SODE's are a different beast and will require a different PR/more discussion, so sticking to OrdinaryDiffEq.jl for now makes sense to me. |
Exactly, I think we should add dependencies as we need them. |
The current set up will not work if the parameters are vectors or matrices. In those cases - what are the parameters that one is actually likely to want to do inference on? Is it all of them or is there an obvious subset to target? |
This PR adds a
bgc_to_ode
wrapper function which can be used to turn a BGC model into an ODEProblem object. The differential equations and inference examples have been simplified accordingly. I have run both examples to check the outputs remain the same and I have also added a small unit test.NOTES: there were issues with compiling a dependancy of DifferentialEquations.jl (BoundaryValueDiffEq.jl) and in the process of debugging that it occurred to me that as long as we aim to only solve ODEs we should use the more lightweight package OrdinaryDiffEq.jl (which also does not have this dependancy). So I updated our dependencies accordingly.