refactor(backend): throw exception instead of returning null #1133

davidyuk · 2021-07-07T07:40:40Z

Known exceptions:

[Vue warn]: Error in mounted hook (Promise/async): "Error: Request failed with 400"

found in

---> <WordDetail> at src/views/WordDetail.vue
       <App> at src/App.vue
         <Root>

when opening details of word with a space in the name (aeternity/tipping-community-backend#368)

GET https://testnet.superhero.aeternity.art/profile/image/ak_2UGL6qArnbWx9fEkJyszssMkCjpu3VeLFBPA6MXYV3APfDSz1k 404

Chrome always report 404 even if they handled, we can't avoid it

I'm proposing a way how errors should be handled:

don't throw an error if it is somehow indicated in ui (red color or a separate modal window)
if an error indicated somehow, it may be printed to console (to be able to debug it in production)

Later all not caught exceptions will show modal asking the user to report it. So we shouldn't have unhandled exceptions, at the same time we shouldn't handle them in a too general fashion (like I'm removing in this PR .catch(() => null)).

How to test this PR:

try all features
ensure that all of them works correctly
report about all exceptions in console (red-colored) that weren't indicated in UI and not mentioned in the list above

fixes #707

github-actions · 2021-07-07T07:50:25Z

Deployed to feature-exception-throwing.aggregator.z52da5wt.xyz, bundle report

thepiwo · 2021-07-07T08:38:13Z

src/components/layout/sendTip/SendTip.vue

-        this.sendingTip = false;
-        if (e.code && e.code === 4) {
+      } catch (error) {
+        if (error.code && error.code === 4) {
          return;


why return without anything?

The author wanted to omit this kind of exceptions. It was introduced in 0b5506d I can't get what is supposed to fix, proposing to remove

ok :D good question

thepiwo · 2021-07-07T08:39:16Z

src/components/tipRecords/Author.vue

@@ -48,8 +48,7 @@ export default {
    },
  },
  async mounted() {
-    const profile = await Backend.getProfile(this.address);
-    this.name = profile ? profile.preferredChainName : null;
+    this.name = (await Backend.getProfile(this.address)).preferredChainName;


we can get the names from the names list in the store, the stored name for an account is also the preferredChainName, as the backend sorts them that way when they are globally fetched. This reduces the number of requests.

I have created #1134 to address this

thepiwo · 2021-07-07T08:41:01Z

src/utils/backend.js

@@ -108,7 +88,7 @@ export default class Backend {
    return backendFetch(`tips${query}`);
  };

-  static addToken = async (address) => backendFetchNoTimeout('tokenCache/addToken', {
+  static addToken = async (address) => backendFetch('tokenCache/addToken', {


this request can take long, when it times out the user gets to see a non working version of word-bazaar, as his token is not indexed and cached properly yet

actually, timeout in backendFetch was removed in 22f0ee4

Liubov-crypto

Trending - pass
Search - pass
Change profile pic- pass, but have to refresh a page to see results
Change back pic - pass
Change profile info - pass
Cookies - pass
Send Tip on the Feed - pass (with some issue)
Retip on the feed - pass (with some issue)
Post without tipping - pass
Add a comment - pass
Tip comment on the feed - pass (with some issue)
Pin/Unpin - pass
Claim - pass
Report post - pass
Voting - pass
Vote - pass
Revoke Vote - pass
Delegate voting power - pass
Create a new poll - pass
Search - pass
Meet - pass
Send a tip to user icon/comment - failed, the same on the product.
Updates - pass
Faq- pass

Change profile pic- pass, but have to refresh a page to see results:

Got this error when tried to send a tip on the feed (tip was sent):

Got this error when tried to retip content on the feed (retip was sent):

Got this error when tried to tip comment on the feed (tip was sent):

Voting:

I accidentally put a space before a wallet address and got this:

Meet:

The error sent tip in the Meet (the same on the product):

Remain:
Go back button affect the iframe wallet
Different names in Meet and wallet

davidyuk · 2021-07-14T04:45:52Z

but have to refresh a page to see results

This one is fixed

Liubov-crypto · 2021-07-14T06:50:32Z

but have to refresh a page to see results

This one is fixed

Cool! Please let me know if there is anything else to check.

davidyuk · 2021-07-15T04:34:10Z

@Liubov-crypto I've added a workaround for v1 tips/retips, please recheck errors from the last review.

Liubov-crypto · 2021-07-15T10:36:37Z

@Liubov-crypto I've added a workaround for v1 tips/retips, please recheck errors from the last review.

Retested, LGTM.

Trending - pass
Search - pass
 Change profile pic- pass
 Change back pic - pass
Change profile info - pass
Cookies - pass
 Send Tip on the Feed - pass
 Retip on the feed - pass
 Post without tipping - pass
Add a comment - pass
Tip comment on the feed - pass
Pin/Unpin - pass
Claim - pass
 Report post - pass
 Voting - pass
Vote - pass
 Revoke Vote - pass
Delegate voting power - pass 
Search - pass
 Meet - pass 
Send a tip to user icon/comment - pass  
Updates - pass 
Faq- pass

github-actions · 2021-08-20T03:35:35Z

SSR will be deployed to superhero.aeternity.io, bundle report

davidyuk force-pushed the feature/exception-throwing branch from 75675e9 to 1a442e6 Compare July 7, 2021 07:47

davidyuk force-pushed the feature/exception-throwing branch from 1a442e6 to 911e6d5 Compare July 7, 2021 07:57

thepiwo reviewed Jul 7, 2021

View reviewed changes

davidyuk force-pushed the feature/exception-throwing branch from 911e6d5 to d77ddfd Compare July 7, 2021 08:43

davidyuk mentioned this pull request Jul 7, 2021

Optimize name retrieving from backend #1134

Open

davidyuk requested review from AtanasKrondev and Liubov-crypto July 7, 2021 09:48

davidyuk marked this pull request as ready for review July 7, 2021 09:48

davidyuk force-pushed the feature/exception-throwing branch from 4dfa640 to 74a4785 Compare July 7, 2021 10:41

Liubov-crypto reviewed Jul 7, 2021

View reviewed changes

davidyuk mentioned this pull request Jul 14, 2021

feat: global error handler, ErrorReportModal #1027

Closed

davidyuk force-pushed the feature/exception-throwing branch from 74a4785 to 2aa659f Compare July 14, 2021 04:43

AtanasKrondev approved these changes Jul 14, 2021

View reviewed changes

davidyuk force-pushed the feature/exception-throwing branch from 2aa659f to 8449e46 Compare July 15, 2021 03:25

davidyuk mentioned this pull request Jul 15, 2021

Gateway Time-out when awaiting tip/retip aeternity/tipping-community-backend#371

Closed

thepiwo approved these changes Jul 21, 2021

View reviewed changes

stale bot added the stale label Jul 28, 2021

stale bot closed this Jul 31, 2021

aeternity deleted a comment from stale bot Aug 20, 2021

CedrikNikita reopened this Aug 20, 2021

stale bot removed the stale label Aug 20, 2021

davidyuk added 4 commits August 20, 2021 13:23

fix(UserInfo): don't request <BACKEND_URL>false

901a324

refactor: add fetchJson function

5a0abb0

refactor(backend): throw exception instead of returning null

fbfe678

refactor: remove handler of unknown error

88ce3c2

davidyuk added 3 commits August 20, 2021 13:34

refactor(UserInfo): simplify js

8b39f58

refactor: consistent error handling

25ba422

fix: omit exceptions thrown by await tip/retip endpoints for v1

b95e11e

CedrikNikita force-pushed the feature/exception-throwing branch from adc5574 to b95e11e Compare August 20, 2021 03:35

CedrikNikita merged commit 95e91a5 into develop Aug 20, 2021

CedrikNikita deleted the feature/exception-throwing branch August 20, 2021 08:21

This was referenced Aug 24, 2021

Broken user profile preview #1153

Closed

fix(user-info): add initial profile, include loading stage #1154

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(backend): throw exception instead of returning null #1133

refactor(backend): throw exception instead of returning null #1133

davidyuk commented Jul 7, 2021 •

edited

Loading

github-actions bot commented Jul 7, 2021

thepiwo Jul 7, 2021

davidyuk Jul 7, 2021

thepiwo Jul 8, 2021

thepiwo Jul 7, 2021

davidyuk Jul 7, 2021

thepiwo Jul 7, 2021

davidyuk Jul 7, 2021

Liubov-crypto left a comment

davidyuk commented Jul 14, 2021

Liubov-crypto commented Jul 14, 2021

davidyuk commented Jul 15, 2021

Liubov-crypto commented Jul 15, 2021

github-actions bot commented Aug 20, 2021

refactor(backend): throw exception instead of returning null #1133

refactor(backend): throw exception instead of returning null #1133

Conversation

davidyuk commented Jul 7, 2021 • edited Loading

github-actions bot commented Jul 7, 2021

thepiwo Jul 7, 2021

Choose a reason for hiding this comment

davidyuk Jul 7, 2021

Choose a reason for hiding this comment

thepiwo Jul 8, 2021

Choose a reason for hiding this comment

thepiwo Jul 7, 2021

Choose a reason for hiding this comment

davidyuk Jul 7, 2021

Choose a reason for hiding this comment

thepiwo Jul 7, 2021

Choose a reason for hiding this comment

davidyuk Jul 7, 2021

Choose a reason for hiding this comment

Liubov-crypto left a comment

Choose a reason for hiding this comment

davidyuk commented Jul 14, 2021

Liubov-crypto commented Jul 14, 2021

davidyuk commented Jul 15, 2021

Liubov-crypto commented Jul 15, 2021

github-actions bot commented Aug 20, 2021

davidyuk commented Jul 7, 2021 •

edited

Loading