Prototype/tip endpoint adjustments #1038
Conversation
thepiwo
force-pushed
the
prototype/tip-endpoint-adjustments
branch
from
2025dd3 to
ae35bdf
Compare
src/components/Avatar.vue
Outdated
| computed: { | ||
| profileIdenticonUrl() { | ||
| return this.chainName | ||
| ? new Avatars(sprites, AVATAR_CONFIG).create(this.chainName) | ||
| : `data:image/svg+xml;base64,${btoa(jdenticon.toSvg(this.address, 32))}`; | ||
| }, | ||
| profileImageUrl({ address, profile }) { |
There was a problem hiding this comment.
this getter depends on mapState
There was a problem hiding this comment.
thanks, still wip :)
There was a problem hiding this comment.
actually it does not, its a prop passed
There was a problem hiding this comment.
address and profile arguments are fields of store's state? As I understand it was provided by mapState. Without mapState the first argument of a computed variable is the current component, but I don't see profile variable defined there, also the comparison address === this.address doesn't make sense then.
src/components/UserInfo.vue
Outdated
| @@ -92,7 +92,7 @@ | |||
| :href="explorerTransactionsUrl" | |||
| > | |||
| <div class="chain"> | |||
| {{ userChainName ? userChainName : $t('FellowSuperhero') }} | |||
| {{ userChainName && userChainName.length ? userChainName[0] : $t('FellowSuperhero') }} | |||
There was a problem hiding this comment.
| {{ userChainName && userChainName.length ? userChainName[0] : $t('FellowSuperhero') }} | |
| {{ userChainName?.length ? userChainName[0] : $t('FellowSuperhero') }} |
There was a problem hiding this comment.
can't seem to use that syntax in the html part
There was a problem hiding this comment.
we have to update to vue@3 to solve this 😄 vuejs/vue#11088, #1047
There was a problem hiding this comment.
I'd be in favour of this :D
thepiwo
force-pushed
the
prototype/tip-endpoint-adjustments
branch
2 times, most recently
from
a158489 to
e8fae7d
Compare
thepiwo
force-pushed
the
prototype/tip-endpoint-adjustments
branch
from
e8fae7d to
7387cd3
Compare
thepiwo
force-pushed
the
prototype/tip-endpoint-adjustments
branch
5 times, most recently
from
4550e6d to
d4d11a9
Compare
thepiwo
force-pushed
the
prototype/tip-endpoint-adjustments
branch
4 times, most recently
from
4bcbfdb to
3f78227
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Before merging we have to revert 1c02cb0 |
AtanasKrondev
force-pushed
the
prototype/tip-endpoint-adjustments
branch
from
6ba97cd to
57ef518
Compare
Thank you @thepiwo ! |
No description provided.