Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return figure after rendering modisco_results plot. #16

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

SeppeDeWinter
Copy link
Collaborator

render_plot(fig, **kwargs)

should be returned at the end of the function (so the created figure can be manipulated).
This is the case for all functions, except crested.pl.patterns.modisco_result.

@LukasMahieu
Copy link
Collaborator

ah, oversight on my part, thanks for the fix 🥇

@LukasMahieu LukasMahieu merged commit 84a205c into main Sep 12, 2024
4 checks passed
@LukasMahieu LukasMahieu deleted the return_plot_crested_pl_patterns_modisco_results branch September 12, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants