[KO-245] Deleting PVC of local volumes during node maintenance. #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhishekdwivedi3060
requested changes
Oct 31, 2023
| @@ -32,7 +32,7 @@ func CheckPodFailed(pod *corev1.Pod) error { | |||
| return fmt.Errorf("pod %s has failed status", pod.Name) | |||
| } | |||
|
|
|||
| if pod.Status.Phase == corev1.PodPending && isPodReasonUnschedulable(pod) { | |||
| if pod.Status.Phase == corev1.PodPending && IsPodReasonUnschedulable(pod) { | |||
There was a problem hiding this comment.
How about moving this pod.Status.Phase == corev1.PodPending inside IsPodReasonUnschedulable and IsPodNeedsToMigrate func ?
There was a problem hiding this comment.
anything is fine. Both functions are just on the conditions, even we can just pass conditions also in these functions.
There was a problem hiding this comment.
Yeah, anything is fine. My thinking was to keep every un-schedulable condition under a func so that we don't have to call multiple conditions ANDed together at multiple places if required.
abhishekdwivedi3060
requested changes
Nov 3, 2023
| It( | ||
| "Should delete local PVC if pod is unschedulable", func() { | ||
| aeroCluster.Spec.Storage.LocalStorageClasses = []string{storageClass} | ||
| aeroCluster.Spec.Storage.CleanLocalPVC = true |
There was a problem hiding this comment.
We should also add a test-case where CleanLocalPVC = false and PVC should not be deleted (i.e. match UUID)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.