Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

非ログイン時はリモートユーザーのFFは一律で非公開として扱うように #88

Merged
merged 2 commits into from
Sep 8, 2024

Conversation

adzukimame
Copy link
Owner

What

  • 非ログイン時はリモートユーザーのFFは一律で非公開として扱うように

Why

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

Copy link

github-actions bot commented Sep 8, 2024

このPRによるapi.jsonの差分

差分はこちら
--- base
+++ head
@@ -1,7 +1,7 @@
 {
   "openapi": "3.1.0",
   "info": {
-    "version": "2024.8.0-mame.2",
+    "version": "2024.8.0-mame.3",
     "title": "Misskey API"
   },
   "externalDocs": {

Get diff files from Workflow Page

Copy link

codecov bot commented Sep 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.78%. Comparing base (516f462) to head (0f1a845).
Report is 1 commits behind head on develop-mame.

Additional details and impacted files
@@               Coverage Diff                @@
##           develop-mame      #88      +/-   ##
================================================
+ Coverage         39.71%   39.78%   +0.06%     
================================================
  Files              1548     1548              
  Lines            191837   191831       -6     
  Branches           2714     3567     +853     
================================================
+ Hits              76197    76319     +122     
+ Misses           115076   114919     -157     
- Partials            564      593      +29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adzukimame adzukimame merged commit 6480aa3 into develop-mame Sep 8, 2024
32 checks passed
@adzukimame adzukimame deleted the fix-user-ff-display-for-guest branch September 8, 2024 08:45
adzukimame added a commit that referenced this pull request Nov 27, 2024
* Revert "非ログイン時はリモートユーザーのFFは一律で非公開として扱うように (#88)"

This reverts commit 6480aa3.

* Revert "リモートユーザーのFFの表示をクレデンシャル必須に (#15)"

This reverts commit 74570bc.

* fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant