Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

非ログイン時にノート数だけを隠し、ノート数の欄はそのまま残すように #87

Merged
merged 2 commits into from
Sep 8, 2024

Conversation

adzukimame
Copy link
Owner

What

  • 非ログイン時にノート数だけを隠し、ノート数の欄はそのまま残すように
  • nodeinfoやstats APIでローカルのノート数を0ではなく1とするように

Copy link

github-actions bot commented Sep 8, 2024

このPRによるapi.jsonの差分

差分はこちら
--- base
+++ head
@@ -1,7 +1,7 @@
 {
   "openapi": "3.1.0",
   "info": {
-    "version": "2024.8.0-mame.1",
+    "version": "2024.8.0-mame.2",
     "title": "Misskey API"
   },
   "externalDocs": {

Get diff files from Workflow Page

Copy link

codecov bot commented Sep 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 39.78%. Comparing base (7e7a5c1) to head (d969e5e).
Report is 1 commits behind head on develop-mame.

Files with missing lines Patch % Lines
...ckages/backend/src/server/NodeinfoServerService.ts 0.00% 2 Missing ⚠️
packages/backend/src/server/api/endpoints/stats.ts 0.00% 2 Missing ⚠️
packages/frontend/src/components/MkUserInfo.vue 0.00% 2 Missing ⚠️
packages/frontend/src/components/MkUserPopup.vue 0.00% 2 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##           develop-mame      #87    +/-   ##
==============================================
  Coverage         39.78%   39.78%            
==============================================
  Files              1548     1548            
  Lines            191837   191837            
  Branches           2712     3562   +850     
==============================================
+ Hits              76321    76323     +2     
+ Misses           114953   114921    -32     
- Partials            563      593    +30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adzukimame adzukimame merged commit 516f462 into develop-mame Sep 8, 2024
32 checks passed
@adzukimame adzukimame deleted the fix-user-notes-display-for-guest branch September 8, 2024 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant