Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ノートの翻訳機能を削除 #353

Merged
merged 1 commit into from
Dec 7, 2024
Merged

Conversation

adzukimame
Copy link
Owner

What

Why

Additional info (optional)

Copy link

github-actions bot commented Dec 7, 2024

このPRによるapi.jsonの差分

差分はこちら
--- base
+++ head
@@ -145,9 +145,6 @@
                     "enableEmail": {
                       "type": "boolean"
                     },
-                    "translatorAvailable": {
-                      "type": "boolean"
-                    },
                     "silencedHosts": {
                       "type": "array",
                       "items": {
@@ -417,15 +414,6 @@
                         "null"
                       ]
                     },
-                    "deeplAuthKey": {
-                      "type": [
-                        "string",
-                        "null"
-                      ]
-                    },
-                    "deeplIsPro": {
-                      "type": "boolean"
-                    },
                     "defaultDarkTheme": {
                       "type": [
                         "string",
@@ -592,7 +580,6 @@
                     "app192IconUrl",
                     "app512IconUrl",
                     "enableEmail",
-                    "translatorAvailable",
                     "silencedHosts",
                     "mediaSilencedHosts",
                     "pinnedUsers",
@@ -646,8 +633,6 @@
                     "perUserHomeTimelineCacheMax",
                     "perUserListTimelineCacheMax",
                     "backgroundImageUrl",
-                    "deeplAuthKey",
-                    "deeplIsPro",
                     "defaultDarkTheme",
                     "defaultLightTheme",
                     "description",
@@ -10192,15 +10177,6 @@
                       "type": "string"
                     }
                   },
-                  "deeplAuthKey": {
-                    "type": [
-                      "string",
-                      "null"
-                    ]
-                  },
-                  "deeplIsPro": {
-                    "type": "boolean"
-                  },
                   "enableEmail": {
                     "type": "boolean"
                   },
@@ -46105,207 +46081,6 @@
         }
       }
     },
-    "/notes/translate": {
-      "post": {
-        "operationId": "notes___translate",
-        "summary": "notes/translate",
-        "description": "No description provided.\n\n**Credential required**: *Yes* / **Permission**: *read:account*",
-        "externalDocs": {
-          "description": "Source code",
-          "url": "https://github.com/adzukimame/misskey/blob/develop/packages/backend/src/server/api/endpoints/notes/translate.ts"
-        },
-        "tags": [
-          "notes"
-        ],
-        "security": [
-          {
-            "bearerAuth": []
-          }
-        ],
-        "requestBody": {
-          "required": true,
-          "content": {
-            "application/json": {
-              "schema": {
-                "type": "object",
-                "properties": {
-                  "noteId": {
-                    "type": "string",
-                    "format": "misskey:id"
-                  },
-                  "targetLang": {
-                    "type": "string"
-                  }
-                },
-                "required": [
-                  "noteId",
-                  "targetLang"
-                ]
-              }
-            }
-          }
-        },
-        "responses": {
-          "200": {
-            "description": "OK (with results)",
-            "content": {
-              "application/json": {
-                "schema": {
-                  "type": "object",
-                  "properties": {
-                    "sourceLang": {
-                      "type": "string"
-                    },
-                    "text": {
-                      "type": "string"
-                    }
-                  },
-                  "required": [
-                    "sourceLang",
-                    "text"
-                  ]
-                }
-              }
-            }
-          },
-          "204": {
-            "description": "OK (without any results)"
-          },
-          "400": {
-            "description": "Client error",
-            "content": {
-              "application/json": {
-                "schema": {
-                  "$ref": "#/components/schemas/Error"
-                },
-                "examples": {
-                  "UNAVAILABLE": {
-                    "value": {
-                      "error": {
-                        "message": "Translate of notes unavailable.",
-                        "code": "UNAVAILABLE",
-                        "id": "50a70314-2d8a-431b-b433-efa5cc56444c"
-                      }
-                    }
-                  },
-                  "NO_SUCH_NOTE": {
-                    "value": {
-                      "error": {
-                        "message": "No such note.",
-                        "code": "NO_SUCH_NOTE",
-                        "id": "bea9b03f-36e0-49c5-a4db-627a029f8971"
-                      }
-                    }
-                  },
-                  "CANNOT_TRANSLATE_INVISIBLE_NOTE": {
-                    "value": {
-                      "error": {
-                        "message": "Cannot translate invisible note.",
-                        "code": "CANNOT_TRANSLATE_INVISIBLE_NOTE",
-                        "id": "ea29f2ca-c368-43b3-aaf1-5ac3e74bbe5d"
-                      }
-                    }
-                  },
-                  "INVALID_PARAM": {
-                    "value": {
-                      "error": {
-                        "message": "Invalid param.",
-                        "code": "INVALID_PARAM",
-                        "id": "3d81ceae-475f-4600-b2a8-2bc116157532"
-                      }
-                    }
-                  }
-                }
-              }
-            }
-          },
-          "401": {
-            "description": "Authentication error",
-            "content": {
-              "application/json": {
-                "schema": {
-                  "$ref": "#/components/schemas/Error"
-                },
-                "examples": {
-                  "CREDENTIAL_REQUIRED": {
-                    "value": {
-                      "error": {
-                        "message": "Credential required.",
-                        "code": "CREDENTIAL_REQUIRED",
-                        "id": "1384574d-a912-4b81-8601-c7b1c4085df1"
-                      }
-                    }
-                  }
-                }
-              }
-            }
-          },
-          "403": {
-            "description": "Forbidden error",
-            "content": {
-              "application/json": {
-                "schema": {
-                  "$ref": "#/components/schemas/Error"
-                },
-                "examples": {
-                  "AUTHENTICATION_FAILED": {
-                    "value": {
-                      "error": {
-                        "message": "Authentication failed. Please ensure your token is correct.",
-                        "code": "AUTHENTICATION_FAILED",
-                        "id": "b0a7f5f8-dc2f-4171-b91f-de88ad238e14"
-                      }
-                    }
-                  }
-                }
-              }
-            }
-          },
-          "418": {
-            "description": "I'm Ai",
-            "content": {
-              "application/json": {
-                "schema": {
-                  "$ref": "#/components/schemas/Error"
-                },
-                "examples": {
-                  "I_AM_AI": {
-                    "value": {
-                      "error": {
-                        "message": "You sent a request to Ai-chan, Misskey's showgirl, instead of the server.",
-                        "code": "I_AM_AI",
-                        "id": "60c46cd1-f23a-46b1-bebe-5d2b73951a84"
-                      }
-                    }
-                  }
-                }
-              }
-            }
-          },
-          "500": {
-            "description": "Internal server error",
-            "content": {
-              "application/json": {
-                "schema": {
-                  "$ref": "#/components/schemas/Error"
-                },
-                "examples": {
-                  "INTERNAL_ERROR": {
-                    "value": {
-                      "error": {
-                        "message": "Internal error occurred. Please contact us if the error persists.",
-                        "code": "INTERNAL_ERROR",
-                        "id": "5d37dbcb-891e-41ca-a3d6-e690c97775ac"
-                      }
-                    }
-                  }
-                }
-              }
-            }
-          }
-        }
-      }
-    },
     "/notes/unrenote": {
       "post": {
         "operationId": "notes___unrenote",
@@ -58828,9 +58603,6 @@
           "canSearchNotes": {
             "type": "boolean"
           },
-          "canUseTranslator": {
-            "type": "boolean"
-          },
           "driveCapacityMb": {
             "type": "integer"
           },
@@ -58876,7 +58648,6 @@
           "inviteExpirationTime",
           "canManageCustomEmojis",
           "canSearchNotes",
-          "canUseTranslator",
           "driveCapacityMb",
           "alwaysMarkNsfw",
           "canUpdateBioMedia",
@@ -59063,9 +58834,6 @@
           "enableEmail": {
             "type": "boolean"
           },
-          "translatorAvailable": {
-            "type": "boolean"
-          },
           "mediaProxy": {
             "type": "string"
           },
@@ -59165,7 +58933,6 @@
           "iconUrl",
           "maxNoteTextLength",
           "enableEmail",
-          "translatorAvailable",
           "mediaProxy",
           "enableUrlPreview",
           "backgroundImageUrl",

Get diff files from Workflow Page

Copy link

codecov bot commented Dec 7, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.

Project coverage is 43.64%. Comparing base (f5a51b4) to head (20b5cca).
Report is 1 commits behind head on develop-mame.

Files with missing lines Patch % Lines
...ackages/frontend/src/components/MkNoteDetailed.vue 0.00% 3 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           develop-mame     #353      +/-   ##
================================================
- Coverage         43.70%   43.64%   -0.06%     
================================================
  Files              1175     1173       -2     
  Lines            148603   148263     -340     
  Branches           3445     3442       -3     
================================================
- Hits              64945    64715     -230     
+ Misses            83658    83548     -110     
Flag Coverage Δ
backend_e2e 55.39% <ø> (-0.37%) ⬇️
backend_unit 27.86% <ø> (+0.05%) ⬆️
frontend_vitest 25.89% <57.14%> (+0.04%) ⬆️
misskey-js 92.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adzukimame adzukimame force-pushed the remove-notes-translate branch from f36c083 to 20b5cca Compare December 7, 2024 16:16
@adzukimame adzukimame merged commit 6b4625a into develop-mame Dec 7, 2024
39 checks passed
@adzukimame adzukimame deleted the remove-notes-translate branch December 7, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant