Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identiconを廃止 #262

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Identiconを廃止 #262

merged 1 commit into from
Nov 8, 2024

Conversation

adzukimame
Copy link
Owner

What

Why

Additional info (optional)

Copy link

github-actions bot commented Nov 8, 2024

このPRによるapi.jsonの差分

差分はこちら
--- base
+++ head
@@ -387,18 +387,12 @@
                         "null"
                       ]
                     },
-                    "enableChartsForRemoteUser": {
-                      "type": "boolean"
-                    },
                     "enableChartsForFederatedInstances": {
                       "type": "boolean"
                     },
                     "enableServerMachineStats": {
                       "type": "boolean"
                     },
-                    "enableIdenticonGeneration": {
-                      "type": "boolean"
-                    },
                     "manifestJsonOverride": {
                       "type": "string"
                     },
@@ -648,10 +642,8 @@
                     "enableTruemailApi",
                     "truemailInstance",
                     "truemailAuthKey",
-                    "enableChartsForRemoteUser",
                     "enableChartsForFederatedInstances",
                     "enableServerMachineStats",
-                    "enableIdenticonGeneration",
                     "manifestJsonOverride",
                     "policies",
                     "enableFanoutTimeline",
@@ -10556,18 +10548,12 @@
                       "null"
                     ]
                   },
-                  "enableChartsForRemoteUser": {
-                    "type": "boolean"
-                  },
                   "enableChartsForFederatedInstances": {
                     "type": "boolean"
                   },
                   "enableServerMachineStats": {
                     "type": "boolean"
                   },
-                  "enableIdenticonGeneration": {
-                    "type": "boolean"
-                  },
                   "serverRules": {
                     "type": "array",
                     "items": {

Get diff files from Workflow Page

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 43.65%. Comparing base (fc551f9) to head (81a2834).
Report is 1 commits behind head on develop-mame.

Files with missing lines Patch % Lines
packages/backend/src/server/ServerService.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           develop-mame     #262      +/-   ##
================================================
+ Coverage         43.63%   43.65%   +0.02%     
================================================
  Files              1192     1191       -1     
  Lines            149330   149171     -159     
  Branches           3412     3411       -1     
================================================
- Hits              65158    65121      -37     
+ Misses            84172    84050     -122     
Flag Coverage Δ
backend_e2e 56.06% <0.00%> (+0.04%) ⬆️
backend_unit 27.90% <0.00%> (+0.04%) ⬆️
frontend_vitest 25.63% <ø> (+<0.01%) ⬆️
misskey-js 92.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adzukimame adzukimame merged commit c5a05d3 into develop-mame Nov 8, 2024
34 checks passed
@adzukimame adzukimame deleted the remove-identicon branch November 8, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant