Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: avoid function on Object in script header #2642

Merged

Conversation

ericoporto
Copy link
Member

@ericoporto ericoporto commented Jan 5, 2025

Same as #2641 but for objects. Related to #2463.

Note that after this there is no more use of function in the script header. The remaining use of function is in the templates and handlers created by the Editor.

And it's also used in this file below (I don't know if the editor use this somewhere?)

function _run_dialog_request (int parmtr) {

@ivan-mogilko
Copy link
Contributor

ivan-mogilko commented Jan 5, 2025

"function _run_dialog_request" is a local helper function used when generating dialog scripts; not exposed to api.
AFAIK it exists purely for handling deprecated "run-script" dialog command.

@ivan-mogilko ivan-mogilko merged commit 56d450a into adventuregamestudio:master Jan 5, 2025
21 checks passed
@ericoporto ericoporto deleted the no-function-in-objects branch January 5, 2025 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants