Add Python 3 compatibility (updated) #19
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request builds from the work by goanpeca in #13.
In addition to the Python 3 compatibility and PEP8 code style fixes in the original branch, these have also been done:
test/test_everything.py
successfully on Python 2 and Python 3VERSION
insetup.py
, so that it behaves as it does in masterWhat hasn't been done:
I haven't done any deep review of the Python 3 changes. There are some issues that would warrant a closer look, but don't seem to cause any problems in testing:
str
still remain when they probably should besix.text_type
I haven't done any manual testing in Python 2 to confirm it works with a live GA account.
I think this is at least at a working point that is worth checking in for a maintainer's feedback, if at least to gauge interest in getting this merged in.