Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes regex to fix the test #45

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Changes regex to fix the test #45

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/test_GtagMP_internal_param_functions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ def test_check_params_event_not_a_dict(self):
]
]

with pytest.raises(AssertionError, match="each event should be a dictionary"):
with pytest.raises(AssertionError, match="each event should be an instance of a dictionary"):
self.gtag._check_params(event_not_a_dict)

def test_check_params_events_incorrect_key(self):
Expand Down Expand Up @@ -113,7 +113,7 @@ def test_check_params_warning(self, capture):

self.gtag._check_params(event_should_get_warning)

expected_log = ('ga4mp.ga4mp', 'WARNING', "WARNING: Event parameters do not match event type.\nFor level_end event type, the correct parameter(s) are ['level_name', 'success'].\nFor a breakdown of currently supported event types and their parameters go here: https://support.google.com/analytics/answer/9267735\n")
expected_log = ('ga4mp.ga4mp', 'WARNING', "WARNING: Event parameters do not match event type.\nFor level_end event type, the correct parameter(s) are ['level_name', 'success'].\nThe parameter 'success' triggered this warning.\nFor a breakdown of currently supported event types and their parameters go here: https://support.google.com/analytics/answer/9267735\n")

capture.check(expected_log)

Expand Down