Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Jenkinsfile for latest snapshot #93

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

reinhapa
Copy link
Contributor

@reinhapa reinhapa commented Nov 5, 2024

No description provided.

Signed-off-by: Patrick Reinhart <[email protected]>
Signed-off-by: Patrick Reinhart <[email protected]>
@aptmac
Copy link
Contributor

aptmac commented Nov 6, 2024

Have you given this Jenkinsfile a run yet? I think the changes look okay, the first thing that comes to mind though is that jmc/core currently requires a jdk17 in the toolchain and jmc/application requires jdk21. So I wasn't sure if having only jdk21 would work here.

@reinhapa
Copy link
Contributor Author

reinhapa commented Nov 7, 2024

I think the changes look okay, the first thing that comes to mind though is that jmc/core currently requires a jdk17

@aptmac there exists a separate build pipeline for this branch here but it's not yet complete I guess.

As for the jdk17: I think that we should be able to bulld jdk17 compatible binaries with a jdk21....

Also I will need some help from a Maven user as I got a different way to sign artifacts, and notarize binaries the eclipse way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants