-
-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add test docker image to ghcr for dynamic VM testing #3775
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A block has been put on this Pull Request as this repository is temporarily under a code freeze due to an ongoing release cycle.
If this pull request needs to be merged during the release cycle then please comment /merge
and a PMC member will be able to remove the block.
If the code freeze is over you can remove this block by commenting /thaw
.
0f129d1
to
cb1ec98
Compare
398390c
to
533f9ba
Compare
3029e29
to
365e78c
Compare
f522eea
to
b98e7e1
Compare
/thaw |
Pull Request unblocked - code freeze is over.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Docker image is loosely based off the dockerStatic Dockerfile that we've been deploying to this point.
I think we should try and avoid having more sets of dockerfiles that we're using at the project as it just becomes harder to maintain. I'm unclear why we've made so many changes relative to the current one in the DockerStatic role. The primary change seems to have been to remove the jenkins user ssh key related stuff, but if that doesn't actively cause a problem I would suggest we leave it in for now and just use the original. If we really need to have differences then perhaps we can parameterise, or if needed grep
out other lines.
This new dockerfile also seems to have removed required packages such as fakeroot
from the files so is already diverging and creating maintenance concerns.
The Docker image is loosely based off the dockerStatic Dockerfile that we've been deploying to this point. This image will be consumed by dynamic test agents as part of adoptium/aqa-tests#5683
We can add more base images as appropriate but I thought I'd keep it simple for now
Checklist