-
-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UnixPB: Extend CRIU role to Linux ppc64le and s390x platforms #2844
base: master
Are you sure you want to change the base?
Conversation
@vsebe Some linter issues to resolve. |
Fixed linter issues. |
c75e2fd
to
16f4184
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - but I'm a non expert here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A block has been put on this Pull Request as this repository is temporarily under a code freeze due to an ongoing release cycle.
If this pull request needs to be merged during the release cycle then please comment /merge
and a PMC member will be able to remove the block.
If the code freeze is over you can remove this block by commenting /thaw
.
1a0d6cf
to
3eecc60
Compare
Build and install CRIU on Linux ppc64le and s390x systems. Add support for CentOS/RHEL 8 and 9. Allow privilege escalation. Signed-off-by: Violeta Sebe <[email protected]>
/thaw |
Pull Request unblocked - code freeze is over.
Failing due to adoptium/temurin-build#3252 |
Re-running at https://ci.adoptium.net/view/Tooling/job/VagrantPlaybookCheck/1655/ now that the freemarker PR has gone into OpenJ9 |
@AdamBrousseau Is this PR still required/desired? |
We have this change on our side. But we also have another 10 changes on top of this one. I'm not sure how you would like to proceed. We can open PR(s) for the rest of the changes, or we can move this PB into our own folder we have in our fork. I'm not sure there is value in having this role at Adopt. |
Gotcha. Let's have a think about this and other such things going forward and discuss next week |
Build and install CRIU on Linux ppc64le and s390x systems.
Add support for CentOS/RHEL 8 and 9.
Allow privilege escalation.
Signed-off-by: Violeta Sebe [email protected]
Checklist