Release from Stage to Main #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…history During promopte use the upload content api instead of copy as the version history is lost. Resolves: MWPW-152581
During promote use the upload content api instead of copy as the version history is lost. The else block for lock file can also be removed as another PR. We still get lock file errors. (Remove else of await sharepoint.saveFile(content, filePath) ) Test: <img width="348" alt="image" src="https://github.com/adobecom/milo-fg/assets/125877471/eb6acb14-a9a2-45fb-8fb0-fc5c64ded030">
…n excel and ui 1. Report as locked when the file is locked / could not be written due to lock (in Copy or Promote) 2. In Parallel waits for all request to be processed before picking next. Using the inparallel (from miloc) which will pick next tasks as and when a previous task compltes 3. Using request wrapper (from miloc) for handling the and option to skip status 4. Timeout or Fetch errors are also retry (as internally reported as 503 instead) 5. Locked flag is passed over for reporting
Copy to floodgate tree also upload files instead of copy to retain version. Opened files will reported as locked
…n excel and ui (#103) Updates 1. Report as locked when the file is locked / could not be written due to file being open (in Copy or Promote) 2. In parallel waits for all request to be processed before picking next. Using the inparallel (from miloc) which will pick next tasks as and when a previous task completes. 3. Using parts of request wrapper (from miloc) for handling the status code and has option to skip status when required. 4. Timeout (Status code 600) or Fetch errors (Status code 503) are also retry 5. Locked flag is passed over for reporting 6. Test cases updated Tests - Scenario 1 - Copy from Main Tree to Floodgate Tree retain version <img width="494" alt="image" src="https://github.com/user-attachments/assets/37ede04b-4bf7-445a-88dd-e1184b6b6120"> Scenario 2 - File is opened and copy is triggered  Scenario 3 - File is locked and copy is triggered | Reported in GUI | Reported in Excel | | -------- | -------- | | <img width="274" alt="image" src="https://github.com/user-attachments/assets/9d4b4a6c-0494-4e8f-a8b9-809ec36b0073"> |  | Scenario 4 - File is opened (or Locked) and promote is triggered | Reported in GUI | Reported in Excel | | -------- | -------- | |  |  |
raga-adbe-gh
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Releases:
MWPW-152581