Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: DNM event leak demo build #7438

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

Conversation

LFDanLu
Copy link
Member

@LFDanLu LFDanLu commented Nov 26, 2024

Closes

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@rspbot
Copy link

rspbot commented Nov 26, 2024

@nwidynski
Copy link
Contributor

Thanks for the build 👍

TLDR; I did not test for every possible interaction for now and also limited the assertions to grid interaction keys only. It's very likely that additional components will also fail when tested more throughly. Point of this demo was to hightlight that many components, not only nested collections, will cause problems when used inside grids.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants