Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Autocomplete wrapper for Menu and ListBox #7181

Open
wants to merge 48 commits into
base: main
Choose a base branch
from

Commits on Oct 9, 2024

  1. Configuration menu
    Copy the full SHA
    c33ac96 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a185473 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2024

  1. Configuration menu
    Copy the full SHA
    e6fa7c1 View commit details
    Browse the repository at this point in the history
  2. fix lint

    LFDanLu committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    61aab83 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2024

  1. rough working version of Menu instead of Listbox in autocomplete

    issues outlined in various comments, basically boils down to ideally using the wrapped collection components state
    LFDanLu committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    66fecc8 View commit details
    Browse the repository at this point in the history
  2. fix submenu

    LFDanLu committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    779309b View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2024

  1. Configuration menu
    Copy the full SHA
    78de7f8 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2024

  1. fix keyboard interactions, and clean up

    ended up going with dispatching events to the menu/menuitem so we can piggyback off of useSelectableCollection and menus press handling for submenutriggers, onAction, and link handling
    LFDanLu committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    e0f098a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5914d11 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    12480fd View commit details
    Browse the repository at this point in the history
  4. update yarn.lock

    LFDanLu committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    ad8942a View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    70c2d0f View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2024

  1. Configuration menu
    Copy the full SHA
    9812c3c View commit details
    Browse the repository at this point in the history
  2. fix build failure

    LFDanLu committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    8478937 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3fbd35f View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2024

  1. fix popover story

    LFDanLu committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    e15d999 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    368a677 View commit details
    Browse the repository at this point in the history
  3. cleanup

    LFDanLu committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    82b3120 View commit details
    Browse the repository at this point in the history
  4. fix build

    LFDanLu committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    423b73c View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2024

  1. Configuration menu
    Copy the full SHA
    6c498f1 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2024

  1. Configuration menu
    Copy the full SHA
    fe5bfbe View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2024

  1. update interaction pattern as per discussion

    for now we will have first item auto focus, no custom announcements, and clear focus on backspace or arrow left/right. See https://docs.google.com/spreadsheets/d/12M--aeeNK4Kruzg8GnO7L-_DUsQE29_bWJzu4yI4-UA/edit?gid=1690380375#gid=1690380375 for a testing matrix
    LFDanLu committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    477ca7f View commit details
    Browse the repository at this point in the history
  2. update yarn.lock

    LFDanLu committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    9a58613 View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2024

  1. Configuration menu
    Copy the full SHA
    574bd67 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ae7a00f View commit details
    Browse the repository at this point in the history
  3. fix lint and scrap custom announcements

    complications making the custom announcements for safari have a delay for when typing ahead but not when using the arrow keys to move through the options, so stashed it for now
    LFDanLu committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    7b11c5d View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2024

  1. intial tests

    LFDanLu committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    04e8777 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    79c9064 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2024

  1. fix lint and add RAC test

    LFDanLu committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    b20b626 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    28afe21 View commit details
    Browse the repository at this point in the history
  3. use MenuSection

    LFDanLu committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    2d0a15f View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2024

  1. (WIP) Refactor autocomplete logic to use custom events to update virt…

    …ual focus (#7378)
    
    * get clear and focus first working with custom events
    
    * fix delayed id update and update id on item hover
    
    * refactor logic to use custom events to move virtual focus instead of a callback ref
    
    * move logic out of menu and down into selection hooks
    
    * use useEvent
    
    didnt use it in autocomplete hook since the ref might not initially exist which is a problem for useEvent (it wont setup the listener)
    LFDanLu authored Nov 20, 2024
    Configuration menu
    Copy the full SHA
    c87a507 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    682357f View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2024

  1. Configuration menu
    Copy the full SHA
    3871e7b View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2024

  1. refactor so that we defer to the child input as much as possible for …

    …behavior
    
    also removes the delay event, readd if we find there can be a batch case where we need to be more careful about the event that is being delayed
    LFDanLu committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    e3c3c35 View commit details
    Browse the repository at this point in the history
  2. cleanup

    LFDanLu committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    04d9a8b View commit details
    Browse the repository at this point in the history
  3. fix listbox test

    LFDanLu committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    0757832 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    fd709a2 View commit details
    Browse the repository at this point in the history
  5. fix build and react 19

    LFDanLu committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    9eede0c View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2024

  1. Configuration menu
    Copy the full SHA
    6bd5270 View commit details
    Browse the repository at this point in the history
  2. clean up some todos

    LFDanLu committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    150bd7e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c13544b View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2024

  1. Configuration menu
    Copy the full SHA
    0d68f68 View commit details
    Browse the repository at this point in the history
  2. initial review comments

    LFDanLu committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    d8c5259 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2024

  1. Configuration menu
    Copy the full SHA
    00f67ad View commit details
    Browse the repository at this point in the history
  2. fix lock

    LFDanLu committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    1a26d79 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    435c6dc View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    df03339 View commit details
    Browse the repository at this point in the history