Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily disable creating the version on rename #99

Merged
merged 2 commits into from
Dec 5, 2024
Merged

Temporarily disable creating the version on rename #99

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9321cbc
Temporarily disable creating the version
bosschaert Dec 4, 2024
263b2f0
Fix linting issue
bosschaert Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/storage/object/copy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
import getObject from './get.js';
import getS3Config from '../utils/config.js';
import { invalidateCollab } from '../utils/object.js';
import { postObjectVersionWithLabel, putObjectWithVersion } from '../version/put.js';
import { putObjectWithVersion } from '../version/put.js';
import { listCommand } from '../utils/list.js';

const MAX_KEYS = 900;
Expand Down Expand Up @@ -77,7 +77,10 @@
type: original.contentType,
});
}
await postObjectVersionWithLabel('Moved', env, daCtx);
// We're doing a rename

// TODO when storing the version make sure to do it from the file that was where there before
// await postObjectVersionWithLabel('Moved', env, daCtx);

Check warning on line 83 in src/storage/object/copy.js

View check run for this annotation

Codecov / codecov/patch

src/storage/object/copy.js#L80-L83 

Added lines #L80 - L83 were not covered by tests

const client = new S3Client(config);
// This is a move so copy to the new location
Expand Down
Loading