Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporarily disable creating the version on rename #99

Merged
merged 2 commits into from
Dec 5, 2024
Merged

Temporarily disable creating the version on rename #99

merged 2 commits into from
Dec 5, 2024

Conversation

bosschaert
Copy link
Contributor

Description

Disable storing a version of the target on a rename that overwrites an existing file.
This will be re-enabled once storing a file on delete is re-enabled.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov Codecov
Copy link

codecov bot commented Dec 4, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 77.41%. Comparing base (2811b46) to head (263b2f0).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/storage/object/copy.js 20.00% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #99      +/-   ##
==========================================
- Coverage   77.54%   77.41%   -0.13%     
==========================================
  Files          38       38              
  Lines        1817     1820       +3     
==========================================
  Hits         1409     1409              
- Misses        408      411       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bosschaert bosschaert requested a review from karlpauls December 5, 2024 06:31
@bosschaert bosschaert merged commit 6c01f9e into main Dec 5, 2024
3 of 5 checks passed
@bosschaert bosschaert deleted the tnvr branch December 5, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karlpauls karlpauls karlpauls approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bosschaert @karlpauls