Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impl Version On Delete for Single Bucket Branch #96

Merged
merged 8 commits into from
Dec 5, 2024

Conversation

bstopp
Copy link
Contributor

@bstopp bstopp commented Dec 3, 2024

Description

Add the change in #86 to the Single Bucket branch.

Motivation and Context

Bring Single Bucket into feature parity with main branch.

How Has This Been Tested?

Added/updated tests.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@bosschaert
Copy link
Contributor

There is a small fix that we need to make atop of this: #95

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 85.43046% with 22 lines in your changes missing coverage. Please review.

Please upload report for BASE (feat/single-bucket@db8825f). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/storage/version/list.js 0.00% 12 Missing ⚠️
src/storage/version/get.js 0.00% 10 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##             feat/single-bucket      #96   +/-   ##
=====================================================
  Coverage                      ?   76.20%           
=====================================================
  Files                         ?       39           
  Lines                         ?     1765           
  Branches                      ?        0           
=====================================================
  Hits                          ?     1345           
  Misses                        ?      420           
  Partials                      ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bstopp bstopp marked this pull request as draft December 4, 2024 08:55
@bstopp bstopp marked this pull request as ready for review December 4, 2024 09:16
@bstopp bstopp marked this pull request as draft December 4, 2024 09:31
@bstopp bstopp marked this pull request as ready for review December 4, 2024 10:21
@bstopp bstopp force-pushed the sb/version-on-delete branch from 2a6679a to 6e8d76e Compare December 5, 2024 08:26
@bstopp bstopp merged commit cecec47 into feat/single-bucket Dec 5, 2024
5 checks passed
@bstopp bstopp deleted the sb/version-on-delete branch December 5, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants