Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support org configuration with multiple sheets #94

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Conversation

bosschaert
Copy link
Contributor

@bosschaert bosschaert commented Dec 3, 2024

Related Issue

Org configuration can now be done in a single or multi sheet.

Fixes #93

Note that the sheet with the admin role configuration still needs to be called data as previously.

How Has This Been Tested?

Locally with da-live/da-collab
Also added unit tests

Screenshots

Screenshot 2024-12-03 at 14 51 13

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.77%. Comparing base (e407d91) to head (0cffc29).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #94      +/-   ##
==========================================
+ Coverage   53.64%   53.77%   +0.12%     
==========================================
  Files          38       38              
  Lines        1795     1800       +5     
==========================================
+ Hits          963      968       +5     
  Misses        832      832              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@auniverseaway auniverseaway merged commit 41f272d into main Dec 4, 2024
5 checks passed
@auniverseaway auniverseaway deleted the mso branch December 4, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support org configuration with multiple sheets
2 participants