Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(handlers): unknownHandler typo #87

Merged
merged 2 commits into from
Dec 4, 2024
Merged

Conversation

hparra
Copy link
Contributor

@hparra hparra commented Oct 16, 2024

Description

Fix typo for unknownHandler and add some tests where that code was use.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Member

@auniverseaway auniverseaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.16%. Comparing base (e407d91) to head (720e55f).
Report is 3 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #87       +/-   ##
===========================================
+ Coverage   53.64%   75.16%   +21.51%     
===========================================
  Files          38       38               
  Lines        1795     1796        +1     
===========================================
+ Hits          963     1350      +387     
+ Misses        832      446      -386     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@auniverseaway auniverseaway merged commit ab79b36 into adobe:main Dec 4, 2024
5 checks passed
This was referenced Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants