Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single Bucket - Move object #74

Merged
merged 6 commits into from
Aug 30, 2024
Merged

Conversation

bstopp
Copy link
Contributor

@bstopp bstopp commented Aug 28, 2024

Description

Final step for single bucket and using R2 Bindings.

How Has This Been Tested?

Added new unit and integration tests.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@bstopp
Copy link
Contributor Author

bstopp commented Aug 28, 2024

All e2e tests in da-live project pass.

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 99.55556% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (feat/single-bucket@f5b941a). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/storage/object/rename.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##             feat/single-bucket      #74   +/-   ##
=====================================================
  Coverage                      ?   75.86%           
=====================================================
  Files                         ?       38           
  Lines                         ?     1682           
  Branches                      ?        0           
=====================================================
  Hits                          ?     1276           
  Misses                        ?      406           
  Partials                      ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bstopp
Copy link
Contributor Author

bstopp commented Aug 28, 2024

Also, perf testing of the certain APIs:

> [email protected] test:perf
> mocha --spec=test/**/*.perf.js



  Object Performance
    ✔ copyObject handles 10000 files in folder (26836ms)
    ✔ copyObject(rename) handles 10000 files in folder (36338ms)
    ✔ move handles 10000 files in folder (36601ms)

@bstopp bstopp merged commit 8cac067 into feat/single-bucket Aug 30, 2024
4 of 5 checks passed
@bstopp bstopp deleted the feat/sb-move-object branch August 30, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants