Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Copy Command Collisions #65

Merged
merged 3 commits into from
Aug 8, 2024
Merged

Fix Copy Command Collisions #65

merged 3 commits into from
Aug 8, 2024

Conversation

bstopp
Copy link
Contributor

@bstopp bstopp commented Jul 15, 2024

Description

Check that source and destination of copy operation are not the same.

Related Issue

Fix #61

Motivation and Context

Copy operations were causing loss of history if pasted to same directory.

How Has This Been Tested?

Added unit tests.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@bstopp bstopp requested a review from bosschaert July 15, 2024 16:23
Copy link

codecov bot commented Jul 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.52%. Comparing base (182f7cd) to head (289591d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #65      +/-   ##
==========================================
+ Coverage   45.31%   47.52%   +2.20%     
==========================================
  Files          38       38              
  Lines        1772     1776       +4     
==========================================
+ Hits          803      844      +41     
+ Misses        969      932      -37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bstopp bstopp merged commit 2696893 into main Aug 8, 2024
5 checks passed
@bstopp bstopp deleted the bug/copy-collisions branch August 8, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Copy operation allows source and destination to be the same causing loss of history
2 participants