Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Authenticated Buckets/Orgs #42

Closed
wants to merge 3 commits into from
Closed

Support Authenticated Buckets/Orgs #42

wants to merge 3 commits into from

Conversation

bstopp
Copy link
Contributor

@bstopp bstopp commented May 3, 2024

Description

Add checks for access to creating buckets, and when creating a new bucket set the access to the authenticated user.

Related Issue

Impl #41

Motivation and Context

So all new buckets are secure going forward.

How Has This Been Tested?

Added unit tests. Also ran some quick Postman checks locally.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@bstopp bstopp requested a review from auniverseaway May 3, 2024 18:45
@bstopp
Copy link
Contributor Author

bstopp commented May 3, 2024

Note: i didn't remove any of the "auto-bucket creation" logic already in saving Objects. However it should be noted that only works in R2, so we'd eventually need another solution if expanding beyond that single storage medium.

(This is also really only used in the new project creation - and I plan to provide an update to that flow soon)

Copy link

codecov bot commented May 3, 2024

Codecov Report

Attention: Patch coverage is 99.25926% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 79.06%. Comparing base (725b972) to head (d2495a2).

Files Patch % Lines
src/utils/auth.js 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #42      +/-   ##
==========================================
- Coverage   79.56%   79.06%   -0.50%     
==========================================
  Files          14       18       +4     
  Lines         915     1094     +179     
==========================================
+ Hits          728      865     +137     
- Misses        187      229      +42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bstopp bstopp closed this Jun 13, 2024
@bstopp bstopp deleted the feat/secure-orgs branch August 7, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant