Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-6 Version Labels #38

Merged
merged 7 commits into from
May 3, 2024
Merged

GH-6 Version Labels #38

merged 7 commits into from
May 3, 2024

Conversation

bosschaert
Copy link
Contributor

@bosschaert bosschaert commented Apr 30, 2024

Description

Make it possible to provide a version display name on the initial version POST/PUT.

Related Issue

#6

How Has This Been Tested?

  • Tested locally with da-collab and da-live
  • Unit tests for all changes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Release notes

  1. Ability to add a label to a version upon creation.

Additional context

Version labels provide a humane context to what a version represents. They can also be helpful for larger larger content projects. Changes happen over a series of days, weeks, or even months. This disjointed nature of content creation makes snapshot-style versions difficult to impossible to use. Being able to label versions provides a way to say in human terms, "rollback to a pre-Adobe MAX 2024 state."

DA Admin is built on top of object storage technologies. This provides a no-nonsense approach to data storage, but it lacks the granular nature of something like a NoSQL database. Object storage metadata is also immutable. What this effectively means is that if you want to update metadata, you must re-write the entire file. Moving version label creation to the POST handler ensures that we can perform one operation to create the version and label.

Copy link

codecov bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.56%. Comparing base (8eabefd) to head (fd8357d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #38      +/-   ##
==========================================
+ Coverage   77.03%   79.56%   +2.52%     
==========================================
  Files          14       14              
  Lines         897      915      +18     
==========================================
+ Hits          691      728      +37     
+ Misses        206      187      -19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@auniverseaway auniverseaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think AEM is right here and would probably lean towards building something familiar...

I would say, label instead of displayname. This is how we would expose it in the UI.

Screenshot 2024-05-01 at 4 39 05 PM

@bosschaert bosschaert changed the title Support passing display name on version POST/PUT Support passing label on version POST/PUT May 2, 2024
@bosschaert
Copy link
Contributor Author

Thanks @auniverseaway I agree label is better so I changed it to that and also added comment.

@bosschaert bosschaert requested a review from auniverseaway May 2, 2024 09:46
auniverseaway
auniverseaway previously approved these changes May 3, 2024
@auniverseaway auniverseaway changed the title Support passing label on version POST/PUT GH-6 Version Labels May 3, 2024
@auniverseaway
Copy link
Member

@bosschaert I approved, but I would remove the comment part. I wouldn't build that out until someone asks for it. Label should do for the foreseeable future and we can always add comment back in later.

@bosschaert bosschaert merged commit 725b972 into main May 3, 2024
5 checks passed
@bosschaert bosschaert deleted the version-desc branch May 3, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants