Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call da-collab back to invalidate and obtain new content if a change originated elsewhere #29

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

bosschaert
Copy link
Contributor

Description

da-collab is reached via a service binding if configured or otherwise through the address specified in the DA_COLLAB env var.

Note that while with this PR test coverage is going up, as src/routes/source.js is now covered, the computed coverage is down as this has now touched some dependencies which are not (yet) covered. This is a drawback of the way coverage was computed.

Related Issue

Fixes #28

Motivation and Context

It allows the editor to be updated when a change is made on the backend storage. This is also used when restoring a version from the UI.

How Has This Been Tested?

  • Unit tests added
  • Also tested locally with da-live and da-collab

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

…ollab

da-collab is reached via a service binding if configured or otherwise
through the address specified in the DA_COLLAB env var.
@bosschaert bosschaert requested a review from karlpauls April 17, 2024 08:44
Copy link

codecov bot commented Apr 17, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 60.55%. Comparing base (844658a) to head (23abfe9).

Files Patch % Lines
src/routes/source.js 88.88% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##              main      #29       +/-   ##
============================================
- Coverage   100.00%   60.55%   -39.45%     
============================================
  Files            4       13        +9     
  Lines          221      829      +608     
============================================
+ Hits           221      502      +281     
- Misses           0      327      +327     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bosschaert bosschaert merged commit c6df3d6 into main Apr 17, 2024
3 of 5 checks passed
@bosschaert bosschaert deleted the svr-inv branch April 17, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Serverside invalidation
2 participants