Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-24 - Allow /api path prefix #25

Merged
merged 2 commits into from
Apr 5, 2024
Merged

GH-24 - Allow /api path prefix #25

merged 2 commits into from
Apr 5, 2024

Conversation

auniverseaway
Copy link
Member

@auniverseaway auniverseaway commented Mar 28, 2024

  • Support prefixing all routes with /api

Resolves: GH-24

How Has This Been Tested?

  1. Passing unit tests
  2. Validated da-admin only uses pathname provided by daCtx.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

* Support prefixing all routes with `/api`

Resolves: GH-24
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (a350e1d) to head (1863498).

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #25   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          219       221    +2     
=========================================
+ Hits           219       221    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@auniverseaway auniverseaway merged commit f51a96a into main Apr 5, 2024
5 checks passed
@auniverseaway auniverseaway deleted the selfhost branch April 5, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow self-hosting da-admin
2 participants