Don't store version on delete

adobe · Dec 4, 2024 · 092088c · 092088c
1 parent 41f272d
commit 092088c
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 11 deletions.
diff --git a/src/storage/object/delete.js b/src/storage/object/delete.js
@@ -27,12 +27,13 @@ async function invalidateCollab(api, url, env) {
 }
 
 export async function deleteObject(client, daCtx, Key, env, isMove = false) {
-  const fname = Key.split('/').pop();
+  // const fname = Key.split('/').pop();
 
-  if (fname.includes('.') && !fname.startsWith('.') && !fname.endsWith('.props')) {
-    const tmpCtx = { ...daCtx, key: Key }; // For next calls, ctx needs the passed
-    await postObjectVersionWithLabel(isMove ? 'Moved' : 'Deleted', env, tmpCtx);
-  }
+  // if (fname.includes('.') && !fname.startsWith('.') && !fname.endsWith('.props')) {
+  //   const tmpCtx = { ...daCtx, key: Key }; // For next calls, ctx needs the passed
+  //   note the Ext also needs to be set ^^^
+  //   await postObjectVersionWithLabel(isMove ? 'Moved' : 'Deleted', env, tmpCtx);
+  // }
 
   let resp;
   try {

diff --git a/test/storage/object/delete.test.js b/test/storage/object/delete.test.js
@@ -71,11 +71,11 @@ describe('Object delete', () => {
 
         const resp = await deleteObject(client, daCtx, 'foo/bar.html', env);
         assert.equal(204, resp.status);
-        assert.deepStrictEqual(['postObjectVersionWithLabel'], postObjVerCalled);
-        assert.deepStrictEqual(
-          ['https://localhost/api/v1/deleteadmin?doc=https://admin.da.live/source/testorg/foo/bar.html'],
-          collabCalled
-        );
+        // assert.deepStrictEqual(['postObjectVersionWithLabel'], postObjVerCalled);
+        // assert.deepStrictEqual(
+        //   ['https://localhost/api/v1/deleteadmin?doc=https://admin.da.live/source/testorg/foo/bar.html'],
+        //   collabCalled
+        // );
       } finally {
         globalThis.fetch = savedFetch;
       }
@@ -219,7 +219,7 @@ describe('Object delete', () => {
 
         const resp = await deleteObject(client, daCtx, 'aha.png', env, true);
         assert.equal(204, resp.status);
-        assert.deepStrictEqual(['postObjectVersionWithLabel'], postObjVerCalled);
+        // assert.deepStrictEqual(['postObjectVersionWithLabel'], postObjVerCalled);
       } finally {
         globalThis.fetch = savedFetch;
       }