Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/pdf viewer #1181

Merged
merged 2 commits into from
Oct 1, 2024
Merged

Bug/pdf viewer #1181

merged 2 commits into from
Oct 1, 2024

Conversation

davidjgonzalez
Copy link
Contributor

@davidjgonzalez davidjgonzalez commented Oct 1, 2024

Fixes #1180

The problem was the viewer.js was included before the registration of the eventlistener, so sometimes the viewer.js would process and emit the event, before the following code could register the listener.

Move the viewer.js before the event registration to fix.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@davidjgonzalez davidjgonzalez merged commit 8fc4254 into adobe:develop Oct 1, 2024
3 of 5 checks passed
@davidjgonzalez davidjgonzalez added this to the 3.8.18 milestone Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PDF Viewer not loading on page refresh
1 participant