Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing downloads action URL to page properties #1055

Conversation

davidjgonzalez
Copy link
Contributor

@davidjgonzalez davidjgonzalez commented Dec 5, 2023

Description

Missing default content results in What's new and FAQ pages to think the actions/downloads should beneath them, rather than the root "search" page. This results in an empty downloads badge.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@davidjgonzalez davidjgonzalez self-assigned this Dec 5, 2023
Copy link

codecov bot commented Dec 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2eab299) 27.26% compared to head (d848cbd) 27.26%.
Report is 8 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #1055   +/-   ##
==========================================
  Coverage      27.26%   27.26%           
  Complexity       517      517           
==========================================
  Files            175      175           
  Lines           4563     4563           
  Branches         653      653           
==========================================
  Hits            1244     1244           
  Misses          3138     3138           
  Partials         181      181           
Flag Coverage Δ
unittests 27.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidjgonzalez davidjgonzalez merged commit fe103e1 into adobe:develop Dec 5, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant