Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new banner design #54

Merged
merged 5 commits into from
Mar 4, 2024
Merged

feat: new banner design #54

merged 5 commits into from
Mar 4, 2024

Conversation

kptdobe
Copy link
Contributor

@kptdobe kptdobe commented Feb 19, 2024

@chicharr as discussed, styling inspired from pagespeed. Some notes:

  • I had to reorganised the css to make the banner and the dialog 2 clearly separated things.
  • I removed the close button from the banner because I did not find how to style it and finally thought it is useless

Test URLs:

@kptdobe kptdobe requested a review from chicharr February 19, 2024 14:06
Copy link

aem-code-sync bot commented Feb 19, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@meryllblanchet
Copy link

@kptdobe your after link returns a 404, I guess there's a typo in the URL. Could you check?

@kptdobe
Copy link
Contributor Author

kptdobe commented Feb 22, 2024

@kptdobe your after link returns a 404, I guess there's a typo in the URL. Could you check?

Oh yes, I relied on the link in the PR default template which is completely wrong. I fixed the link here and in the PR template (see 9e4be3d)

@aem-code-sync aem-code-sync bot temporarily deployed to cookieconsent-css February 22, 2024 08:16 Inactive
Copy link

aem-code-sync bot commented Feb 22, 2024

Page Scores Audits Google
/block-collection/cookie-consent-demo PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link
Collaborator

@chicharr chicharr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kptdobe thanks, it looks much nicer now :)
PSI Accessibility check complains about the low contrast ratio in the banner
Screenshot 2024-02-26 at 10 12 43

@chicharr chicharr merged commit b5bb05c into cookieconsent Mar 4, 2024
3 checks passed
@chicharr chicharr deleted the cookieconsent-css branch March 4, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants