Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent background scrolling when a modal is open #38

Merged
merged 1 commit into from
Jan 19, 2024
Merged

Prevent background scrolling when a modal is open #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions blocks/modal/modal.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
body.modal-open {
overflow: hidden;
}

.modal dialog {
--dialog-border-radius: 16px;

Expand Down
7 changes: 6 additions & 1 deletion blocks/modal/modal.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,10 @@ export async function createModal(contentNodes) {
await loadBlock(block);
decorateIcons(closeButton);

dialog.addEventListener('close', () => block.remove());
dialog.addEventListener('close', () => {
document.body.classList.remove('modal-open');
block.remove();
});

block.append(dialog);
return {
Expand All @@ -48,6 +51,8 @@ export async function createModal(contentNodes) {
// Google Chrome restores the scroll position when the dialog is reopened,
// so we need to reset it.
setTimeout(() => { dialogContent.scrollTop = 0; }, 0);

document.body.classList.add('modal-open');
},
};
}
Expand Down