Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Youtube and Vimeo to Video block #35

Merged
merged 3 commits into from
Jan 19, 2024
Merged

Add support for Youtube and Vimeo to Video block #35

merged 3 commits into from
Jan 19, 2024

Conversation

synox
Copy link
Collaborator

@synox synox commented Jan 11, 2024 •
edited
Loading

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Jan 11, 2024 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Jan 11, 2024 •
edited
Loading

Page Scores Audits Google
/block-collection/video PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@synox synox requested review from shsteimer and fkakatie January 11, 2024 21:57
fkakatie
fkakatie reviewed Jan 11, 2024
View reviewed changes
blocks/video/video.js Outdated Show resolved Hide resolved
@synox
Copy link
Collaborator Author

synox commented Jan 19, 2024

@fkakatie do you think this is ready to merge?

fkakatie
fkakatie approved these changes Jan 19, 2024
View reviewed changes
Copy link
Member

@fkakatie fkakatie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to be honest, I genuinely thought this had already been merged.

@synox synox merged commit e2c5841 into main Jan 19, 2024
3 checks passed
@synox synox deleted the video branch January 19, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fkakatie fkakatie fkakatie approved these changes

@shsteimer shsteimer Awaiting requested review from shsteimer

@andreituicu andreituicu Awaiting requested review from andreituicu

@chicharr chicharr Awaiting requested review from chicharr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Embed block should include Video block features
2 participants
@synox @fkakatie