Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: lightweight quote block #28

Merged
merged 3 commits into from
Jan 11, 2024
Merged

feat: lightweight quote block #28

merged 3 commits into from
Jan 11, 2024

Conversation

fkakatie
Copy link
Member

proposed DOM structure:

<blockquote>
  <div class="quote-quotation">
    <p> ... </p>
  </div>
  <div class="quote-attribution">
    <p> ... <cite> ... </cite> </p>
  </div>
</blockquote>

Test URLs:

Copy link

aem-code-sync bot commented Jan 10, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Jan 10, 2024

Page Scores Audits Google
/block-collection/quote PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@@ -0,0 +1,29 @@
.quote blockquote {
margin: 0;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would change the style

    max-width: 60%;
    margin: 0 auto;
    font-style: italic;

and for quote-attribution:

text-align: right;

Screenshot 2024-01-10 at 09 49 25

@fkakatie fkakatie merged commit c44fa81 into main Jan 11, 2024
3 checks passed
@fkakatie fkakatie deleted the quote branch January 11, 2024 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants