Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated blocks (and supporting files) to reference aem.js instead of … #17 #18

Merged
merged 2 commits into from
Oct 25, 2023
Merged

Conversation

davidjgonzalez
Copy link
Contributor

…lib-franklin.js so copy/paste of blocks from the collection work on new projects from boilerplate moving forward

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix #14

Verified the project test suite passes:

 Executing task: npm run test 


> @adobe/[email protected] test
> wtr "./test/**/*.test.js" --node-resolve --port=2000 --coverage


test/scripts/scripts.test.js:

 🚧 404 network requests:
    - nav.plain.html
    - footer.plain.html

test/scripts/block-utils.test.js:

 🚧 Browser logs:
      ping:test { foo: 'bar' }
      ping:cwv { foo: 'bar' }

 🚧 404 network requests:
    - test/scripts/nope.css
    - undefined/blocks/hero/hero.css

test/blocks/fragment/fragment.test.js:

 🚧 Browser logs:
      failed to load module for example TypeError: Failed to fetch dynamically imported module: http://localhost:2000/blocks/example/example.js
      failed to load module for example TypeError: Failed to fetch dynamically imported module: http://localhost:2000/blocks/example/example.js
      failed to load module for example TypeError: Failed to fetch dynamically imported module: http://localhost:2000/blocks/example/example.js
      failed to load module for example TypeError: Failed to fetch dynamically imported module: http://localhost:2000/blocks/example/example.js

 🚧 404 network requests:
    - blocks/example/example.css
    - does/not/exist.plain.html

test/blocks/header/header.test.js:

 🚧 404 network requests:
    - blocks/example/example.js

Chrome: |██████████████████████████████| 6/6 test files | 18 passed, 0 failed

Code coverage: 89.71 %
View full coverage report at coverage/lcov-report/index.html

Finished running tests in 2.1s, all tests passed! 🎉

 *  Terminal will be reused by tasks, press any key to close it. 

Test URLs:

davidjgonzalez and others added 2 commits October 17, 2023 15:11
…lib-franklin.js so copy/paste of blocks from the collection work on new projects from boilerplate moving forward
@aem-code-sync
Copy link

aem-code-sync bot commented Oct 17, 2023

Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

@aem-code-sync
Copy link

aem-code-sync bot commented Oct 17, 2023

Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@fkakatie fkakatie self-requested a review October 25, 2023 20:01
@davidnuescheler
Copy link
Contributor

thanks @davidjgonzalez

@davidnuescheler davidnuescheler merged commit 9ab886b into adobe:main Oct 25, 2023
4 checks passed
@davidjgonzalez davidjgonzalez deleted the aemjs branch November 17, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants